Closed Bug 1494737 Opened 6 years ago Closed 6 years ago

The pref checks in bug 1491061 are still not right

Categories

(Firefox :: Protections UI, enhancement, P1)

Product:
Firefox
Component:
Protections UI
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Bug 1494737 - Don't check browser.contentblocking.ui.enabled in AntiTrackingCommon::ShouldHonorContentBlockingCookieRestrictions()
46 bytes, text/x-phabricator-request
baku
: review+
pascalc
: approval-mozilla-beta+
Details | Review
The beta landing yesterday bounced again because of two more test failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=a5e0c4e767747994f72b53e8b6073395663f72f1 The enterprise policy test failure shows that we should not be checking browser.contentblocking.ui.enabled after all, since that breaks blocking all third-part cookies on beta when that pref is disabled. :-(
In my patch here I'm fixing the tests in a very hacky way to ease the backport. We should fix up the tests to remove blockingByContentBlockingUI for example later in a patch that won't get uplifted.
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 9012677 [details] Bug 1494737 - Don't check browser.contentblocking.ui.enabled in AntiTrackingCommon::ShouldHonorContentBlockingCookieRestrictions() Andrea Marchesini [:baku] has approved the revision.
Attachment #9012677 - Flags: review+
Comment on attachment 9012677 [details] Bug 1494737 - Don't check browser.contentblocking.ui.enabled in AntiTrackingCommon::ShouldHonorContentBlockingCookieRestrictions() Approval Request Comment This is the last piece needed for bug 1491061, please see the approval request in that bug for risk analysis etc.
Attachment #9012677 - Flags: approval-mozilla-beta?
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/197cb402f89a Don't check browser.contentblocking.ui.enabled in AntiTrackingCommon::ShouldHonorContentBlockingCookieRestrictions(); r=baku
Comment on attachment 9012677 [details] Bug 1494737 - Don't check browser.contentblocking.ui.enabled in AntiTrackingCommon::ShouldHonorContentBlockingCookieRestrictions() test fixes for bug 1491061, uplift approved for 63 beta 11
Attachment #9012677 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/mozilla-central/rev/197cb402f89a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: