1494772 - favicon mismatch with tab icon and bookmark icon

Status: NEW

(Firefox :: Bookmarks & History, defect, P5)

Description

[click-click]

Attachment: MediumDPI.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20180621064021

Steps to reproduce:

1. Go to https://forums.mydigitallife.net/ and save it as a bookmark.




Actual results:

2. Depending on the DPI being used for the display, the icon used for the tab (bulb.ico) and the bookmark icon may differ.


Expected results:

3. If using a normal DPI (100%) the favicon.ico is used for both tab and bookmark.
4. If using a medium DPI (125%) a  different icon (logo.og.png) is used for the bookmark 

This behavior is inconsistent and the favicon.ico should persist for both tab and bookmark independent of the DPI setting being used. The issue applies to Win7, Win8 and Win10.

Comment 1

[click-click]

Issue Applies to Firefox 60.2.1Esr and &2.0.2

Comment 2

[click-click]

This is the 1st time I've reported a bug here. So what happens next and will a response be forthcoming?

Comment 3

[Marco Bonardo [:mak]]

We have a possible solution for this in bug 1494016, it won't be an immediate fix though, it's not our top priority at the moment.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:mak, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 8

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 9

[click-click]

It's still applicable. Needs very little effort to verify. I'm currently on Firefox ESR 102.3.0. I assume this will never be fixed. Am I correct?

Comment 10

[click-click]

(In reply to click-click from comment #9)

It's still applicable and relevant. Needs very little effort to verify. I'm currently on Firefox ESR 102.3.0. I assume this will never be fixed. Am I correct?

Comment 11

[Markus Koller]

Seeing this as well, a few test cases:

• https://mail.proton.me/
• https://calendar.proton.me/
• https://web.whatsapp.com/

These all work correctly in Chromium.

Comment 12

[Markus Koller]

(In reply to Markus Koller from comment #11)

Forgot to mention: I'm on Firefox 122.0.1, and reproduced in latest nightly now as well.

Comment 13

[Marco Bonardo [:mak]]

The reason is always the same, in most cases the site is not serving good icons.
We have a couple bugs on file to improve the situation there.
What matters the most anyway is that the site is recognizable, there's nothing mandating the bookmarks must use the same icon as the tabs.

Comment 14

[Markus Koller]

(In reply to Marco Bonardo [:mak] from comment #13)

The reason is always the same, in most cases the site is not serving good icons.
We have a couple bugs on file to improve the situation there.
What matters the most anyway is that the site is recognizable, there's nothing mandating the bookmarks must use the same icon as the tabs.

I did contact Proton about this and they blamed Firefox, and I guess they might have good reasons for preferring certain icons as fallbacks for certain clients. From Firefox's side, it does seem like just weird UX to use different icons in different contexts for no apparent reason.

And I do keep not recognizing the WhatsApp fallback icon on my bookmark bar, since it's mostly just a white circle with a very thin green logo outline inside :) Proton is even worse since they have a white background in their fallback icon, so I resorted to hacking around it in userChrome.css.

Comment 15

[Marco Bonardo [:mak]]

Unfortunately I don't have a Proton account to check the icons when logged in, the login page icon works fine so I can't tell what's up. They should provide either an svg, or both 16px and 32px icons.

To make an example of why I say the sites are serving bad icons, Whatsapp serves https://web.whatsapp.com/img/favicon/1x/favicon.png that is a 16px icon not suitable for an hi-dpi monitor that needs at least a 32px icon to avoid showing a blurry mess. (we'll fix the whatsapp case showing a blurry icon in the future, as it looks like that's what they want)
Let alone sites that are serving icons with no-store and then complain we don't store them (not this case, but it's quite common).

Comment 16

[Markus Koller]

Oh right, here are the favicons from https://mail.proton.me/ while logged in:

<link rel="icon" href="/assets/favicon.ico" sizes="any">
<link rel="icon" href="/assets/favicon.ico" sizes="1025x1025">
<link rel="icon" href="/assets/favicon.d47d3d0bef6d338e377a.svg?v=5.0.36.5" type="image/svg+xml">

So they serve a 64x64px ICO (with the unfortunate white background) and an SVG, which seems to be what Firefox uses for the tab.

Public links for convenience:

• https://mail.proton.me/assets/favicon.ico
• https://mail.proton.me/assets/favicon.d47d3d0bef6d338e377a.svg?v=5.0.36.5

Comment 17

[Marco Bonardo [:mak]]

The bug on Proton is https://bugzilla.mozilla.org/show_bug.cgi?id=1772264, so they're right we should fix it.
What's your DPI settings in the OS (global zoom level on Windows or MacOS or Linux)?

Comment 18

[Andy Bajka]

It would be best if there was a function to delete the favicon from the sqlite database and the cached favicon image. That way favicon errors could be corrected by first deleting them. Right now it's virtually impossible to delete or change incorrect favicon's.