Closed Bug 1494809 Opened 1 year ago Closed 1 year ago

Implement webgl exts for BPTC and RGTC

Categories

(Core :: Canvas: WebGL, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: gfx-noted)

Attachments

(4 files, 1 obsolete file)

These are draft extensions for now, and so behind a flag.
Just waiting on the spec to solidify:
https://github.com/KhronosGroup/WebGL/pull/2721
The WG rejected this extension.

Depends on D8034
Attached file Bug 1494809 - Mark test failures. (obsolete) —
Depends on D8035
Flags: needinfo?(kyle)
Flags: needinfo?(kvark)
Jeff, what info are you requesting here? Is this an invitation to review?
Flags: needinfo?(kvark)
Blocking review is requested from you on most of the patches here, but I only got review from you on the first patch. Is it not notifying you of the latter ones?
Flags: needinfo?(kvark)
Oh, I see now, thanks for the heads up! I thought Bugzilla would tell me with a big red circle if something needs a review, but neither it or Phabricator are screaming at me. Just need to get used to the latter. Will review tonight/tomorrow, sorry about the delay.
Thanks!
The point of my confusion here is that with no comment on "needinfo?" I'm looking at this page and nothing clearly tells me an immediate action is required. Maybe I'm using it wrong, but it seems to be a workflow problem with Phabricator.
Flags: needinfo?(kvark)
Yeah, I'm less than impressed compared with MozReview.
Backed out 7 changesets (bug 1494809) for build bustage at build/src/dom/canvas/WebGLTextureUpload.cpp

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/e031a41a8250a927ab1cb21e7b4092b3e2c9638f

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=linux,x64,debug,build-linux64-base-toolchains%2Fdebug,(bb)&selectedJob=204413405&revision=076aed819da6fe4a762fe294937afea76f888b0b

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=204413405&repo=mozilla-inbound&lineNumber=39819

task 2018-10-10T04:52:27.271Z] 04:52:27     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2018-10-10T04:52:27.272Z] 04:52:27     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_dom_canvas5.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/canvas -I/builds/worker/workspace/build/src/obj-firefox/dom/canvas -I/builds/worker/workspace/build/src/js/xpconnect/wrappers -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/dom/workers -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/gfx/angle/checkout/include -I/builds/worker/workspace/build/src/gfx/gl -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/js/xpconnect/src -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/media/libyuv/libyuv/include -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -Wno-error=shadow -Wno-missing-braces  -MD -MP -MF .deps/Unified_cpp_dom_canvas5.o.pp   /builds/worker/workspace/build/src/obj-firefox/dom/canvas/Unified_cpp_dom_canvas5.cpp
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dom/canvas/Unified_cpp_dom_canvas5.cpp:92:0:
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  /builds/worker/workspace/build/src/dom/canvas/WebGLTextureUpload.cpp: In lambda function:
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  /builds/worker/workspace/build/src/dom/canvas/WebGLTextureUpload.cpp:1022:32: error: suggest parentheses around comparison in operand of '&' [-Werror=parentheses]
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -           if (format->d & target == LOCAL_GL_TEXTURE_3D)
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  cc1plus: all warnings being treated as errors
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1118: recipe for target 'Unified_cpp_dom_canvas5.o' failed
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  make[4]: *** [Unified_cpp_dom_canvas5.o] Error 1
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  make[4]: *** Waiting for unfinished jobs....
[task 2018-10-10T04:52:32.272Z] 04:52:32     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2018-10-10T04:52:32.272Z] 04:52:32     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_dom_canvas0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/canvas -I/builds/worker/workspace/build/src/obj-firefox/dom/canvas -I/builds/worker/workspace/build/src/js/xpconnect/wrappers -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/dom/workers -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/gfx/angle/checkout/include -I/builds/worker/workspace/build/src/gfx/gl -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/js/xpconnect/src -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/media/libyuv/libyuv/include -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -Wno-error=shadow -Wno-missing-braces  -MD -MP -MF .deps/Unified_cpp_dom_canvas0.o.pp   /builds/worker/workspace/build/src/obj-firefox/dom/canvas/Unified_cpp_dom_canvas0.cpp
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'dom/canvas/target' failed
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make[3]: *** [dom/canvas/target] Error 2
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:32: recipe for target 'compile' failed
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make[2]: *** [compile] Error 2
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  /builds/worker/workspace/build/src/config/rules.mk:423: recipe for target 'default' failed
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make[1]: *** [default] Error 2
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  client.mk:151: recipe for target 'build' failed
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make: *** [build] Error 2
[task 2018-10-10T04:52:32.297Z] 04:52:32     INFO -  353 compiler warnings present.
[task 2018-10-10T04:52:32.352Z] 04:52:32     INFO -  Notification center failed: Install notify-send (usually part of the libnotify package) to get a notification when the build finishes.
[task 2018-10-10T04:52:32.377Z] 04:52:32    ERROR - Return code: 2
[task 2018-10-10T04:52:32.377Z] 04:52:32  WARNING - setting return code to 2
[task 2018-10-10T04:52:32.377Z] 04:52:32    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2018-10-10T04:52:32.377Z] 04:52:32    FATAL - Running post_fatal callback...
[task 2018-10-10T04:52:32.377Z] 04:52:32    FATAL - Exiting -1
[task 2018-10-10T04:52:32.378Z] 04:52:32     INFO - [mozharness: 2018-10-10 04:52:32.378032Z] Finished build step (failed)
[task 2018-10-10T04:52:32.378Z] 04:52:32     INFO - Running post-run listener: _summarize
[task 2018-10-10T04:52:32.378Z] 04:52:32    ERROR - # TBPL FAILURE #
[task 2018-10-10T04:52:32.378Z] 04:52:32     INFO - [mozharness: 2018-10-10 04:52:32.378287Z] FxDesktopBuild summary:
[task 2018-10-10T04:52:32.378Z] 04:52:32    ERROR - # TBPL FAILURE #
Flags: needinfo?(jgilbert)
Flags: needinfo?(kyle)
Blocks: 1507263
Attachment #9015371 - Attachment is obsolete: true
Flags: needinfo?(jgilbert)
Blocks: 1452830
You need to log in before you can comment on or make changes to this bug.