1494809 - Implement webgl exts for BPTC and RGTC

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P3)

Description

[Kelsey Gilbert [:jgilbert]]

These are draft extensions for now, and so behind a flag.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Just waiting on the spec to solidify:
https://github.com/KhronosGroup/WebGL/pull/2721

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1494809 - Update gfx/gl/GLConsts.h. -

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1494809 - Support WebGL exts for BPTC and RGTC. -

Depends on D8032

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1494809 - Don't include WebGLFormats.h in WebGLContext.h. -

Depends on D8033

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1494809 - Remove WebGL ATC support. -

The WG rejected this extension.

Depends on D8034

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1494809 - Mark test failures.

Depends on D8035

Comment 7

[Dzmitry Malyshau [:kvark]]

Jeff, what info are you requesting here? Is this an invitation to review?

Comment 8

[Kelsey Gilbert [:jgilbert]]

Blocking review is requested from you on most of the patches here, but I only got review from you on the first patch. Is it not notifying you of the latter ones?

Comment 9

[Dzmitry Malyshau [:kvark]]

Oh, I see now, thanks for the heads up! I thought Bugzilla would tell me with a big red circle if something needs a review, but neither it or Phabricator are screaming at me. Just need to get used to the latter. Will review tonight/tomorrow, sorry about the delay.

Comment 10

[Kelsey Gilbert [:jgilbert]]

Thanks!

Comment 11

[Dzmitry Malyshau [:kvark]]

The point of my confusion here is that with no comment on "needinfo?" I'm looking at this page and nothing clearly tells me an immediate action is required. Maybe I'm using it wrong, but it seems to be a workflow problem with Phabricator.

Comment 12

[Kelsey Gilbert [:jgilbert]]

Yeah, I'm less than impressed compared with MozReview.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e98c2a51aa8f
Update gfx/gl/GLConsts.h. - r=kvark
https://hg.mozilla.org/integration/mozilla-inbound/rev/6106836daf58
Support WebGL exts for BPTC and RGTC. - r=kvark,qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/be2ec3c05d10
Don't include WebGLFormats.h in WebGLContext.h. - r=kvark
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2612f006753
Remove WebGL ATC support. - r=kvark,qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/101b4c98aad8
Mark test failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/076aed819da6
Also remove now-useless #ifdef FOO\n#error.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89e092c992ae
Fix python lint errors.

Comment 15

[Cristina Coroiu [:ccoroiu]]

Backed out 7 changesets (bug 1494809) for build bustage at build/src/dom/canvas/WebGLTextureUpload.cpp

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/e031a41a8250a927ab1cb21e7b4092b3e2c9638f

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=linux,x64,debug,build-linux64-base-toolchains%2Fdebug,(bb)&selectedJob=204413405&revision=076aed819da6fe4a762fe294937afea76f888b0b

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=204413405&repo=mozilla-inbound&lineNumber=39819

task 2018-10-10T04:52:27.271Z] 04:52:27     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2018-10-10T04:52:27.272Z] 04:52:27     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_dom_canvas5.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/canvas -I/builds/worker/workspace/build/src/obj-firefox/dom/canvas -I/builds/worker/workspace/build/src/js/xpconnect/wrappers -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/dom/workers -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/gfx/angle/checkout/include -I/builds/worker/workspace/build/src/gfx/gl -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/js/xpconnect/src -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/media/libyuv/libyuv/include -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -Wno-error=shadow -Wno-missing-braces  -MD -MP -MF .deps/Unified_cpp_dom_canvas5.o.pp   /builds/worker/workspace/build/src/obj-firefox/dom/canvas/Unified_cpp_dom_canvas5.cpp
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dom/canvas/Unified_cpp_dom_canvas5.cpp:92:0:
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  /builds/worker/workspace/build/src/dom/canvas/WebGLTextureUpload.cpp: In lambda function:
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  /builds/worker/workspace/build/src/dom/canvas/WebGLTextureUpload.cpp:1022:32: error: suggest parentheses around comparison in operand of '&' [-Werror=parentheses]
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -           if (format->d & target == LOCAL_GL_TEXTURE_3D)
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  cc1plus: all warnings being treated as errors
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1118: recipe for target 'Unified_cpp_dom_canvas5.o' failed
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  make[4]: *** [Unified_cpp_dom_canvas5.o] Error 1
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2018-10-10T04:52:27.273Z] 04:52:27     INFO -  make[4]: *** Waiting for unfinished jobs....
[task 2018-10-10T04:52:32.272Z] 04:52:32     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2018-10-10T04:52:32.272Z] 04:52:32     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_dom_canvas0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/canvas -I/builds/worker/workspace/build/src/obj-firefox/dom/canvas -I/builds/worker/workspace/build/src/js/xpconnect/wrappers -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/dom/workers -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/gfx/angle/checkout/include -I/builds/worker/workspace/build/src/gfx/gl -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/js/xpconnect/src -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/media/libyuv/libyuv/include -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -Wno-error=shadow -Wno-missing-braces  -MD -MP -MF .deps/Unified_cpp_dom_canvas0.o.pp   /builds/worker/workspace/build/src/obj-firefox/dom/canvas/Unified_cpp_dom_canvas0.cpp
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'dom/canvas/target' failed
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make[3]: *** [dom/canvas/target] Error 2
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:32: recipe for target 'compile' failed
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make[2]: *** [compile] Error 2
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  /builds/worker/workspace/build/src/config/rules.mk:423: recipe for target 'default' failed
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make[1]: *** [default] Error 2
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  client.mk:151: recipe for target 'build' failed
[task 2018-10-10T04:52:32.273Z] 04:52:32     INFO -  make: *** [build] Error 2
[task 2018-10-10T04:52:32.297Z] 04:52:32     INFO -  353 compiler warnings present.
[task 2018-10-10T04:52:32.352Z] 04:52:32     INFO -  Notification center failed: Install notify-send (usually part of the libnotify package) to get a notification when the build finishes.
[task 2018-10-10T04:52:32.377Z] 04:52:32    ERROR - Return code: 2
[task 2018-10-10T04:52:32.377Z] 04:52:32  WARNING - setting return code to 2
[task 2018-10-10T04:52:32.377Z] 04:52:32    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2018-10-10T04:52:32.377Z] 04:52:32    FATAL - Running post_fatal callback...
[task 2018-10-10T04:52:32.377Z] 04:52:32    FATAL - Exiting -1
[task 2018-10-10T04:52:32.378Z] 04:52:32     INFO - [mozharness: 2018-10-10 04:52:32.378032Z] Finished build step (failed)
[task 2018-10-10T04:52:32.378Z] 04:52:32     INFO - Running post-run listener: _summarize
[task 2018-10-10T04:52:32.378Z] 04:52:32    ERROR - # TBPL FAILURE #
[task 2018-10-10T04:52:32.378Z] 04:52:32     INFO - [mozharness: 2018-10-10 04:52:32.378287Z] FxDesktopBuild summary:
[task 2018-10-10T04:52:32.378Z] 04:52:32    ERROR - # TBPL FAILURE #

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/651195783637
Update gfx/gl/GLConsts.h. - r=kvark
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae8e6587acbc
Support WebGL exts for BPTC and RGTC. - r=kvark,qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/798ec47e6c16
Don't include WebGLFormats.h in WebGLContext.h. - r=kvark
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e4cbde27912
Remove WebGL ATC support. - r=kvark,qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e5f7a79d011
Mark test failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f685fe1ceef
Also remove now-useless #ifdef FOO\n#error.
https://hg.mozilla.org/integration/mozilla-inbound/rev/63cefc2ebc6a
Fix python lint errors.

Comment 17

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/651195783637
https://hg.mozilla.org/mozilla-central/rev/ae8e6587acbc
https://hg.mozilla.org/mozilla-central/rev/798ec47e6c16
https://hg.mozilla.org/mozilla-central/rev/9e4cbde27912
https://hg.mozilla.org/mozilla-central/rev/6e5f7a79d011
https://hg.mozilla.org/mozilla-central/rev/2f685fe1ceef
https://hg.mozilla.org/mozilla-central/rev/63cefc2ebc6a