1494948 - Extend or remove FX_PREFERENCES_OPENED_VIA probe

Status: RESOLVED FIXED

(Firefox :: Preferences, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

FX_PREFERENCES_OPENED_VIA (https://mzl.la/2zCbSBj) expired in 63 and we should either extend it or remove it, including the origin parameter for openPreferences (https://searchfox.org/mozilla-central/rev/6d1ab84b4b39fbfb9505d4399857239bc15202ef/browser/base/content/utilityOverlay.js#806)

Jared, do you think this is still needed?

Comment 1

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

No, I think it can be removed now. If needed we can look at the data that was already collected to see where most of the users are came from.

Comment 3

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

We should also remove the FX_PREFERENCES_CATEGORY_OPENED and FX_PREFERENCES_CATEGORY_OPENED_V2 probes.

Comment 4

[Manish [:manishkk] [On Break]]

Removed under bug: 1502019

(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #3)

We should also remove the FX_PREFERENCES_CATEGORY_OPENED and
FX_PREFERENCES_CATEGORY_OPENED_V2 probes.

Comment 5

[Manish [:manishkk] [On Break]]

Attachment: Bug 1494948 Extend or remove FX_PREFERENCES_OPENED_VIA probe

Comment 6

[Manish [:manishkk] [On Break]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da33c793de6fcbe42c755d989739960739ec52ed

Comment 8

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Hi Manish, are you able to continue working on this bug?

Comment 9

[Manish [:manishkk] [On Break]]

Sorry, I am not able to give enough time for this. I can try this week. else u can assign this to someone else.

Comment 10

[Johann Hofmann [:johannh]]

Ok, no worries, Trushita, would you be interested in taking this over? You should take a look at the review in Phabricator to figure out what's left to be done here.

Thanks!

Comment 11

[trushita]

Yes! I would like to work on it.

Comment 12

[Johann Hofmann [:johannh]]

Great, thanks!

Comment 13

[Johann Hofmann [:johannh]]

Hi Trushita, are you still working on this? We would need to resolve this sooner rather than later for bug 1485464, so please let me know if you think you'll be able to put up a patch any time soon or if you need any help. Thank you!

Comment 14

[trushita]

Yes Johann. I will be submitting a patch in a few hours. Should I put you in review?

Comment 15

[trushita]

Attachment: Bug 1494948: Removed FX_PREFERENCES_OPENED_VIA probe and origin parameter for openPreferences

Removed FX_PREFERENCES_OPENED_VIA probe as it expired in 63.Origin parameter for openPreferences has also been removed.

Comment 16

[trushita]

(In reply to trushita from comment #14)

Yes Johann. I will be submitting a patch in a few hours. Should I put you in review?

Submitted the patch for review to Jared.

Comment 17

[Johann Hofmann [:johannh]]

Thanks! That's perfect.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28416f5a55b5
Removed FX_PREFERENCES_OPENED_VIA probe and origin parameter for openPreferences r=jaws,chutten

Comment 19

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/28416f5a55b5