Closed Bug 1494948 Opened Last year Closed 7 months ago

Extend or remove FX_PREFERENCES_OPENED_VIA probe

Categories

(Firefox :: Preferences, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: johannh, Assigned: trushita)

References

Details

Attachments

(1 file, 1 obsolete file)

FX_PREFERENCES_OPENED_VIA (https://mzl.la/2zCbSBj) expired in 63 and we should either extend it or remove it, including the origin parameter for openPreferences (https://searchfox.org/mozilla-central/rev/6d1ab84b4b39fbfb9505d4399857239bc15202ef/browser/base/content/utilityOverlay.js#806)

Jared, do you think this is still needed?
Flags: needinfo?(jaws)
Priority: -- → P3
No, I think it can be removed now. If needed we can look at the data that was already collected to see where most of the users are came from.
Flags: needinfo?(jaws)
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Duplicate of this bug: 1502019
We should also remove the FX_PREFERENCES_CATEGORY_OPENED and FX_PREFERENCES_CATEGORY_OPENED_V2 probes.
Assignee: prathikshaprasadsuman → nobody
Status: ASSIGNED → NEW

Removed under bug: 1502019

(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #3)

We should also remove the FX_PREFERENCES_CATEGORY_OPENED and
FX_PREFERENCES_CATEGORY_OPENED_V2 probes.

Assignee: nobody → 1991manish.kumar

Hi Manish, are you able to continue working on this bug?

Flags: needinfo?(1991manish.kumar)

Sorry, I am not able to give enough time for this. I can try this week. else u can assign this to someone else.

Flags: needinfo?(1991manish.kumar)

Ok, no worries, Trushita, would you be interested in taking this over? You should take a look at the review in Phabricator to figure out what's left to be done here.

Thanks!

Assignee: 1991manish.kumar → nobody
Flags: needinfo?(trushita)

Yes! I would like to work on it.

Flags: needinfo?(trushita)

Great, thanks!

Assignee: nobody → trushita
Status: NEW → ASSIGNED

Hi Trushita, are you still working on this? We would need to resolve this sooner rather than later for bug 1485464, so please let me know if you think you'll be able to put up a patch any time soon or if you need any help. Thank you!

Flags: needinfo?(trushita)

Yes Johann. I will be submitting a patch in a few hours. Should I put you in review?

Flags: needinfo?(trushita) → needinfo?(jhofmann)

Removed FX_PREFERENCES_OPENED_VIA probe as it expired in 63.Origin parameter for openPreferences has also been removed.

(In reply to trushita from comment #14)

Yes Johann. I will be submitting a patch in a few hours. Should I put you in review?

Submitted the patch for review to Jared.

Flags: needinfo?(jhofmann)

Thanks! That's perfect.

Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28416f5a55b5
Removed FX_PREFERENCES_OPENED_VIA probe and origin parameter for openPreferences r=jaws,chutten
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Attachment #9039996 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.