1495030 - Add GV API for blocking third-party tracker cookies

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Focus would like [1] to offer separate options for blocking third-party *tracker* cookies separate from blocking *all* third-party cookies. Firefox desktop is adding a new tracker cookie blocklist. The GV API will need a way to specify this new tracker cookie blocklist.

Is the new tracker cookie blocklist in Firefox 63 or 64?

[1] Provide similar auto privacy features than Desktop: https://github.com/mozilla-mobile/focus-android/issues/3319

Comment 1

[Chris Peterson [:cpeterson]]

Focus issue: Additional Cookie Protection Option (3rd party tracker cookies)

https://github.com/mozilla-mobile/focus-android/issues/3515

Comment 2

[Chris Peterson [:cpeterson]]

P1 because the Focus team would like this feature for Focus 8.0. TBD whether GV 63 has the tracker cookie blocklist that they need. GV 64 won't ship until December 12, after Focus 8.0 will ship.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Eugen will sort this out.

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1495030-1.0-Add-third-party-tracker-cookies-bloc.patch

Looks like it's simply an additional cookie behaviour (pref) value we need to expose.

Comment 5

[François Marier [:francois]]

Comment on attachment 9014522 [details] [diff] [review]
0001-Bug-1495030-1.0-Add-third-party-tracker-cookies-bloc.patch

Review of attachment 9014522 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, but let's just double-check with baku since he's the one who added this new cookie option.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dcf2e242b3a
[1.0] Add third-party tracker cookies blocking setting. r=snorp,baku

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/8dcf2e242b3a

Comment 8

[Chris Peterson [:cpeterson]]

Eugen, can we uplift this new API to GV 63 Beta? The Focus team would like to expose this setting to users in Focus 8.0 (which will ship GV 63).

Comment 9

[Eugen Sawin [:esawin]]

Comment on attachment 9014522 [details] [diff] [review]
0001-Bug-1495030-1.0-Add-third-party-tracker-cookies-bloc.patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Third-party tracker cookie blocking

User impact if declined: Focus will not be able to expose tracker cookie blocking setting for desktop-parity.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This only exposes an additional pref value through an existing GeckoView API.

String changes made/needed: None

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9014522 [details] [diff] [review]
0001-Bug-1495030-1.0-Add-third-party-tracker-cookies-bloc.patch

Minimal patch, P1 for Geckoview, uplift approved for 63 beta 13, thanks.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/af52aa2742c4