1495081 - Content Blocking on/off switch's tooltip not shown

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1476217 also added a tooltip to the on/off switch of Content Blocking:

content-blocking-toggle-on =
  .tooltiptext = Turn Off Content Blocking
content-blocking-toggle-off =
  .tooltiptext = Turn On Content Blocking

This doesn't work at the moment.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1495081 - Content Blocking on/off switch's tooltip not shown. r?johannh

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 9012989 [details]
Bug 1495081 - Content Blocking on/off switch's tooltip not shown. r?johannh

Johann Hofmann [:johannh] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7764656611ce
Content Blocking on/off switch's tooltip not shown. r=johannh

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7764656611ce

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta approval request?

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 9012989 [details]
Bug 1495081 - Content Blocking on/off switch's tooltip not shown. r?johannh

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1476217

User impact if declined: No tooltip for switch button to toggle content blocking shown (might affect a11y)

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Not risky, just requests one more property of an existing l10n entity object

String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9012989 [details]
Bug 1495081 - Content Blocking on/off switch's tooltip not shown. r?johannh

Low risk, polish on a new 63 feature, uplift approved for 63 beta 14, thanks.

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e2029ae27c94

Comment 9

[Saheda Reza [:Antora]]

I have reproduced the bug on nightly according to (2018-09-28)

Fixing bug is verified on latest Beta--
Build ID    :20181122182000
User Agent  :Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0


this tool-tip has added
Tested OS--Windows10 64bit