Checkbox/radio control problem

VERIFIED FIXED

Status

()

Core
Layout: Form Controls
P3
enhancement
VERIFIED FIXED
19 years ago
18 years ago

People

(Reporter: Michael Lowe, Assigned: rods (gone))

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

19 years ago
Perform this sequence of events

1. Mouse into a checkbox/radio control
2. Press left mouse button down
3. Mouse out of control
4. Lift left mouse button

Notice the control has still retained the mouse down state

Updated

19 years ago
Assignee: karnaze → kmcclusk

Comment 1

19 years ago
Reassigning to Kevin.

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → WORKSFORME
I tested this on test8.html using WIN32 apprunner build from Sept 27, 1999 10:00
with gfx checkboxes and radio buttons and it works properly for me.

When I mouse down the radio button or checkbox is rendered as active.
If I move out of the radio button or checkbox and release they go back to their
non-active appearance and the click does not change their state.

Marking as  worksforme
(Reporter)

Updated

19 years ago
Status: RESOLVED → REOPENED
(Reporter)

Comment 3

19 years ago
Created attachment 1901 [details]
Screenshot of problem
(Reporter)

Updated

19 years ago
Resolution: WORKSFORME → ---
(Reporter)

Comment 4

19 years ago
Attached before and after screenshot of problem on 28/9/1999 build.
(Reporter)

Updated

19 years ago
Severity: normal → enhancement
(Reporter)

Comment 5

19 years ago
It turns out that this is not a problem with the code, but is the result of the
:focus style that is set in html.css.   It would be better if the :focus style
was more like it is for native Windows controls - that is having a 1px dotted
outline around the control text label, instead of the current Mozilla style (an
inset border).
(Reporter)

Comment 6

19 years ago
Created attachment 2549 [details] [diff] [review]
Patch file to fix visual problem
(Reporter)

Updated

19 years ago
Assignee: kmcclusk → rods
Status: REOPENED → NEW
(Reporter)

Comment 7

19 years ago
Attached is a patch which fixes the visual focus problem with radio controls as
well as bringing the visual style of disabled and readonly edit controls into
line with how they are formated on Window, and prevents visual focus on disabled
select controls.  Hope you can review it for checkin.   This bug can then be
closed.
(Assignee)

Updated

18 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

18 years ago
I did not use the attached fix (should have, I know). But this looks like I
fixed it when I fixed all the ordering of the hove, focus, active rules for all
the form controls. marking fixed.

Comment 9

18 years ago
QA Contact update.

Comment 10

18 years ago
Updating QA contact.
QA Contact: ckritzer → bsharma

Comment 11

18 years ago
Works for Me
Platform: PC
OS: Windows 98
Mozilla Version: 2000100508

Marking as Verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.