1495160 - WEBRTC_DATACHANNEL_NEGOTIATED Telemetry broken since 59

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Nils Ohlmeier [:drno]]

Looking at https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2018-03-14&include_spill=0&keys=__none__!__none__!__none__&max_channel_version=nightly%252F60&measure=WEBRTC_DATACHANNEL_NEGOTIATED&min_channel_version=null&processType=*&product=Firefox&sanitize=0&sort_keys=submissions&start_date=2018-01-22&table=1&trim=0&use_submission_date=0 from Nightly 60 on WEBRTC_DATACHANNEL_NEGOTIATED only ever reports no data channel at all.

My guess is that something in 59, probably Transceivers, broke this stat.

Comment 1

[Nils Ohlmeier [:drno]]

I also tested this locally by doing a Datachannel only PeerConnection and checking about:telemetry before and after. And the count for WEBRTC_DATACHANNEL_NEGOTIATED went up by on for no data channel, even though only a data channel got established.

Comment 2

[Nils Ohlmeier [:drno]]

Byron could you please have a look how this would be to fix?

Comment 3

[Byron Campen [:bwc]]

This doesn't look very hard.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ea232ae77a569547831bbb9aeb2258ff02229dd

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4b5b76893dfa40d8308ce3301bc86991a71d266

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1495160: Count datachannel "tracks" properly again.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18725d7ee61d
Count datachannel "tracks" properly again. r=mjf

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/18725d7ee61d