1495163 - blob invalidation: SVG animation issues

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P4)

Description

[709922234]

Attachment: Screen Shot 2018-09-29 at 11.33.29.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:64.0) Gecko/20100101 Firefox/64.0
Build ID: 20180928220433

Steps to reproduce:

1. open https://x.yupoo.com/
2. scroll page


Actual results:

svg has the wrong color block

Comment 1

[Darkspirit]

Thanks!

Comment 2

[Darkspirit]

Attachment: lazy.html

* There is no smooth transition/fade in of the green points when not moving the mouse
* SVG icons can be highly pixelated at first
* Sometimes there is a light green box like seen in attachment 9013061 [details] that grows to the size of the whole circle and disappears

Comment 3

[Darkspirit]

(The whole thing ran into bug 1455841 (2018-04-20). Same regression and fix range. Today's three issues already existed before.)

first bad = all three issues
mozregression --good 2018-01-15 --bad 2018-04-19 --pref gfx.webrender.all:true -a https://bug1495163.bmoattachments.org/attachment.cgi?id=9013107
> 40:22.30 INFO: Last good revision: 38cfaf35c4c1b2761c97c78769496b3181a6eedc
> 40:22.30 INFO: First bad revision: 2a2282923b5abdf8b95bad5a59e694ac8e744883
> 40:22.30 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=38cfaf35c4c1b2761c97c78769496b3181a6eedc&tochange=2a2282923b5abdf8b95bad5a59e694ac8e744883

> 2a2282923b5a	Jeff Muizelaar — Bug 1450015. Enable blob invalidation by default. r=gankro

Comment 4

[Darkspirit]

Attachment: 2018-09-29_20-35-42.mp4

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 64. We could still take a patch for 65, and if it's verified and doesn't seem risky, could still take fixes for 64 as well.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

I think this might be related to the scale stuff.

Comment 7

[Timothy Nikkel (:tnikkel)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)
> I think this might be related to the scale stuff.

The patch from bug 1415987 does fix the obvious problems here, but I'm not sure if there are still smaller, less frequent glitches of a different type.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

:darkspirit, do you still see anything wrong here?

Comment 9

[Darkspirit]

All issues from comment 2 seem to be fixed. I'll file a separate bug about a regression causing the circle to flicker.

mozregression --find-fix --bad 2018-09-29 --good 2018-12-24 --pref gfx.webrender.all:true -a https://bug1495163.bmoattachments.org/attachment.cgi?id=9013107
> 21:38.60 INFO: First good revision: 996bf60e0fce90cc42e7b59201d56ba0947b8cf2
> 21:38.60 INFO: Last bad revision: f1ce520b1d0d0223ee117796ead6551881ec4fc6
> 21:38.60 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f1ce520b1d0d0223ee117796ead6551881ec4fc6&tochange=996bf60e0fce90cc42e7b59201d56ba0947b8cf2

> 996bf60e0fce	Timothy Nikkel — Bug 1415987. Use ChooseScale to choose a scale in WebRender. r=jrmuizel
> 640e15aa79b9	Jeff Muizelaar — Bug 1415987. Factor out ChooseScale from ChooseScaleAndSetTransform in FrameLayerBuilder. r=tnikkel

Comment 10

[Darkspirit]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #9)
> I'll file a separate bug about a regression causing the circle to flicker.

1.
Actually, that bug was present before..
Just press F5 often. Sometimes the circle will flash white.

2.
If you zoom in by Ctrl+mousewheel while the animation is running, lines of the circle are misplaced. Does not happen without WebRender.

Comment 11

[Darkspirit]

I couldn't reproduce the issues from comment 10 on Win10/GTX1060, but on Debian Testing/X11/Macbook Pro.
Maybe it could still be  reproducible on Win10 with older/weaker Nvidia cards?

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Closing. Please reopen if there's still an issue here.