Closed
Bug 1495190
Opened 7 years ago
Closed 7 years ago
Remove unused toolkit/themes/shared/in-content/check.svg
Categories
(Toolkit :: Themes, enhancement, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: ntim, Assigned: korina.houghtaling, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file, 2 obsolete files)
|
659 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Bug 1491609 removed all usages of that file, but didn't remove the file itself.
|
Reporter | |
Updated•7 years ago
|
Mentor: ntim.bugs
Hi! This bug only requires removing unused toolkit/themes/shared/in-content/check.svg correct?
Attachment #9013177 -
Flags: review+
Attachment #9013177 -
Flags: feedback+
|
|
Reporter | |
Comment 3•7 years ago
|
||
Comment on attachment 9013177 [details] [diff] [review]
mypatch.diff
Review of attachment 9013177 [details] [diff] [review]:
-----------------------------------------------------------------
This seems like the wrong patch.
Attachment #9013177 -
Flags: review+
Attachment #9013177 -
Flags: feedback+
|
|
Reporter | |
Comment 4•7 years ago
|
||
(In reply to Korina from comment #1)
> Hi! This bug only requires removing unused
> toolkit/themes/shared/in-content/check.svg correct?
That is correct.
|
||
Updated•7 years ago
|
Priority: -- → P3
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #3)
> Comment on attachment 9013177 [details] [diff] [review]
> mypatch.diff
>
> Review of attachment 9013177 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> This seems like the wrong patch.
I forgot to do a fresh pull. However, now my patch file is really long for some reason. Do you have any clue what I'm doing wrong? I'll post the new patch.
|
|
Reporter | |
Comment 7•7 years ago
|
||
I'm not sure, can you try "hg up central --clean" ?
|
|
Reporter | |
Comment 10•7 years ago
|
||
Comment on attachment 9015718 [details] [diff] [review]
patch.diff
Review of attachment 9015718 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, thanks! Asked a peer to review it.
Attachment #9015718 -
Flags: review?(dao+bmo)
|
|
Reporter | |
Updated•7 years ago
|
Attachment #9015704 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•7 years ago
|
Attachment #9013177 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → korina.houghtaling
|
|
||
Updated•7 years ago
|
Attachment #9015718 -
Flags: review?(dao+bmo) → review+
|
||
Comment 11•7 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77d431411954
Remove unused toolkit/themes/shared/in-content/check.svg. r=dao
|
||
Comment 12•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•