Closed Bug 1495190 Opened 3 years ago Closed 3 years ago

Remove unused toolkit/themes/shared/in-content/check.svg

Categories

(Toolkit :: Themes, enhancement, P3)

Product:
Toolkit
Component:
Themes
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: ntim, Assigned: korina.houghtaling, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file, 2 obsolete files)

patch.diff
659 bytes, patch
dao
: review+
Details | Diff | Splinter Review 
Bug 1491609 removed all usages of that file, but didn't remove the file itself.
Mentor: ntim.bugs
Hi! This bug only requires removing  unused toolkit/themes/shared/in-content/check.svg correct?
Attached patch mypatch.diff (obsolete) — — Splinter Review
Attachment #9013177 - Flags: review+
Attachment #9013177 - Flags: feedback+
Comment on attachment 9013177 [details] [diff] [review]
mypatch.diff

Review of attachment 9013177 [details] [diff] [review]:
-----------------------------------------------------------------

This seems like the wrong patch.
Attachment #9013177 - Flags: review+
Attachment #9013177 - Flags: feedback+
(In reply to Korina from comment #1)
> Hi! This bug only requires removing  unused
> toolkit/themes/shared/in-content/check.svg correct?

That is correct.
Priority: -- → P3
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #3)
> Comment on attachment 9013177 [details] [diff] [review]
> mypatch.diff
> 
> Review of attachment 9013177 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This seems like the wrong patch.

I forgot to do a fresh pull. However, now my patch file is really long for some reason. Do you have any clue what I'm doing wrong?  I'll post the new patch.
Attached patch mypatch.diff (obsolete) — — Splinter Review 
I'm not sure, can you try "hg up central --clean" ?
That worked! Thanks so much. Adding the patch now.
Attached patch patch.diff — — Splinter Review 
Comment on attachment 9015718 [details] [diff] [review]
patch.diff

Review of attachment 9015718 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks! Asked a peer to review it.
Attachment #9015718 - Flags: review?(dao+bmo)
Attachment #9015704 - Attachment is obsolete: true
Attachment #9013177 - Attachment is obsolete: true
Assignee: nobody → korina.houghtaling
Attachment #9015718 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77d431411954
Remove unused toolkit/themes/shared/in-content/check.svg. r=dao
https://hg.mozilla.org/mozilla-central/rev/77d431411954
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.