Closed Bug 1495249 Opened 3 years ago Closed 3 years ago
Post Effects Visual Overflow Rect use the first continuations/block-in-inline siblings for SVG observers
Bug 1495249. Make ComputePostEffectsVisualOverflowRect use the first continuations/block-in-inline siblings for SVG. r?longsonr
46 bytes, text/x-phabricator-request
|Details | Review|
In bug 1494355 I inadvertently switched us from using 'firstFrame' to 'aFrame' to store/retrieve the observer in when calling GetAndObserveFilters in ComputePostEffectsVisualOverflowRect: https://hg.mozilla.org/mozilla-central/rev/5177bb8cb2ce#l4.33 That is bad, and causes us to fail the MOZ_ASSERT that I add to GetOrCreateFilterObserverListForCSS in bug 1495215. (Note to anyone wondering why we don't use irstContinuationOrIBSplitSibling in nsSVGUtils - it's because SVG doesn't have continuations or block-in-inline.)
Comment on attachment 9013118 [details] Bug 1495249. Make ComputePostEffectsVisualOverflowRect use the first continuations/block-in-inline siblings for SVG. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9013118 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/87f643635a12 Make ComputePostEffectsVisualOverflowRect use the first continuation/block-in-inline sibling for SVG. r=longsonr
You need to log in before you can comment on or make changes to this bug.