Make ComputePostEffectsVisualOverflowRect use the first continuations/block-in-inline siblings for SVG observers

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

9 months ago
In bug 1494355 I inadvertently switched us from using 'firstFrame' to 'aFrame' to store/retrieve the observer in when calling GetAndObserveFilters in ComputePostEffectsVisualOverflowRect:

https://hg.mozilla.org/mozilla-central/rev/5177bb8cb2ce#l4.33

That is bad, and causes us to fail the MOZ_ASSERT that I add to GetOrCreateFilterObserverListForCSS in bug 1495215.

(Note to anyone wondering why we don't use irstContinuationOrIBSplitSibling in nsSVGUtils - it's because SVG doesn't have continuations or block-in-inline.)
Comment on attachment 9013118 [details]
Bug 1495249. Make ComputePostEffectsVisualOverflowRect use the first continuations/block-in-inline siblings for SVG. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9013118 - Flags: review+

Comment 3

9 months ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/87f643635a12
Make ComputePostEffectsVisualOverflowRect use the first continuation/block-in-inline sibling for SVG. r=longsonr

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/87f643635a12
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.