Closed
Bug 1495249
Opened 6 years ago
Closed 6 years ago
Make ComputePostEffectsVisualOverflowRect use the first continuations/block-in-inline siblings for SVG observers
Categories
(Core :: SVG, enhancement, P3)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
In bug 1494355 I inadvertently switched us from using 'firstFrame' to 'aFrame' to store/retrieve the observer in when calling GetAndObserveFilters in ComputePostEffectsVisualOverflowRect: https://hg.mozilla.org/mozilla-central/rev/5177bb8cb2ce#l4.33 That is bad, and causes us to fail the MOZ_ASSERT that I add to GetOrCreateFilterObserverListForCSS in bug 1495215. (Note to anyone wondering why we don't use irstContinuationOrIBSplitSibling in nsSVGUtils - it's because SVG doesn't have continuations or block-in-inline.)
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9013118 [details] Bug 1495249. Make ComputePostEffectsVisualOverflowRect use the first continuations/block-in-inline siblings for SVG. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9013118 -
Flags: review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/87f643635a12 Make ComputePostEffectsVisualOverflowRect use the first continuation/block-in-inline sibling for SVG. r=longsonr
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/87f643635a12
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•