'Hide Bookmarks Toolbar' is invisible(black on black) on Dark theme

VERIFIED FIXED in Firefox 64

Status

()

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Importance:
P1
normal
Status:
VERIFIED FIXED
Opened:
9 months ago
Updated:
8 months ago

People

(Reporter: euthanasia_waltz, Assigned: dao)

Tracking

({regression})

Version:
64 Branch
Target:
Firefox 64
Platform:
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox62 unaffected, firefox63 unaffected, firefox64 verified)

Details

Attachments

(1 attachment)

Bug 1495291 - Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r?paolo
46 bytes, text/x-phabricator-request
Paolo
: review+
Details | Review
Reporter

Description

•
9 months ago 
Library -> Bookmarks -> Bookmarking Tools -> Hide Bookmarks Toolbar
background-color: rgba(0, 0, 0, 0);
color: rgb(74, 74, 74);
I cannot see text and icon unless mouse hover.

'Hide Bookmarks Sidebar' doesn't have this issue.
background-color: rgba(0, 0, 0, 0);
color: rgb(255, 255, 255);

(Linux only. No problem on Windows)
 Assignee

Updated

•
9 months ago
Blocks: 1391948
 Assignee

Updated

•
9 months ago
Assignee: nobody → dao+bmo
Blocks: 1492130
Severity: minor → normal
Status: UNCONFIRMED → NEW
Component: Theme → Bookmarks & History
Depends on: 1495442
Ever confirmed: true
Keywords: regression
Priority: -- → P1

Comment 2

•
9 months ago 
Comment on attachment 9013551 [details]
Bug 1495291 - Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r?paolo

:Paolo Amadini has approved the revision.
Attachment #9013551 - Flags: review+

Comment 3

•
9 months ago 
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/554b31d816d1
Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r=paolo

Comment 4

•
9 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/554b31d816d1
Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64

Comment 5

•
8 months ago 
I have reproduced this issue using Firefox  64.0a1 (2018.09.30) on Ubuntu 16.04 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0b4, on Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.