Closed Bug 1495291 Opened 3 years ago Closed 3 years ago

'Hide Bookmarks Toolbar' is invisible(black on black) on Dark theme

Categories

(Firefox :: Bookmarks & History, defect, P1)

Product:
Firefox
Component:
Bookmarks & History
Version:
64 Branch
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 --- verified

People

(Reporter: euthanasia_waltz, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1495291 - Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r?paolo
46 bytes, text/x-phabricator-request
Paolo
: review+
Details | Review 
Library -> Bookmarks -> Bookmarking Tools -> Hide Bookmarks Toolbar
background-color: rgba(0, 0, 0, 0);
color: rgb(74, 74, 74);
I cannot see text and icon unless mouse hover.

'Hide Bookmarks Sidebar' doesn't have this issue.
background-color: rgba(0, 0, 0, 0);
color: rgb(255, 255, 255);

(Linux only. No problem on Windows)
Blocks: 1391948
Assignee: nobody → dao+bmo
Blocks: 1492130
Severity: minor → normal
Status: UNCONFIRMED → NEW
Component: Theme → Bookmarks & History
Depends on: 1495442
Ever confirmed: true
Keywords: regression
Priority: -- → P1
Comment on attachment 9013551 [details]
Bug 1495291 - Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r?paolo

:Paolo Amadini has approved the revision.
Attachment #9013551 - Flags: review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/554b31d816d1
Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r=paolo
https://hg.mozilla.org/mozilla-central/rev/554b31d816d1
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
I have reproduced this issue using Firefox  64.0a1 (2018.09.30) on Ubuntu 16.04 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0b4, on Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.