1495291 - 'Hide Bookmarks Toolbar' is invisible(black on black) on Dark theme

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[atlanto]

Library -> Bookmarks -> Bookmarking Tools -> Hide Bookmarks Toolbar
background-color: rgba(0, 0, 0, 0);
color: rgb(74, 74, 74);
I cannot see text and icon unless mouse hover.

'Hide Bookmarks Sidebar' doesn't have this issue.
background-color: rgba(0, 0, 0, 0);
color: rgb(255, 255, 255);

(Linux only. No problem on Windows)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1495291 - Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r?paolo

Comment 2

[:Paolo Amadini]

Comment on attachment 9013551 [details]
Bug 1495291 - Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r?paolo

:Paolo Amadini has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/554b31d816d1
Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r=paolo

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/554b31d816d1

Comment 5

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox  64.0a1 (2018.09.30) on Ubuntu 16.04 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0b4, on Ubuntu 16.04 x64.