Rename `PayerErrorFields` to `PayerErrors`

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P1
trivial
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: marcosc, Assigned: marcosc)

Tracking

({dev-doc-complete})

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

()

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

9 months ago
Being renamed in the spec for consistency.
Assignee

Updated

9 months ago
Assignee

Comment 1

9 months ago
Working on it...
Assignee: nobody → mcaceres
Severity: normal → trivial
Status: NEW → ASSIGNED
Priority: P3 → P1
Assignee

Comment 2

9 months ago
Posted patch Rename all the things... (obsolete) — Splinter Review
Attachment #9013210 - Flags: review?(echuang)
Comment on attachment 9013210 [details] [diff] [review]
Rename all the things...

Review of attachment 9013210 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe I misunderstood something, do you attach the correct patch?
I didn't see any renaming code for PayerErrors.
Assignee

Comment 4

9 months ago
Attachment #9013210 - Attachment is obsolete: true
Attachment #9013210 - Flags: review?(echuang)
Attachment #9013255 - Flags: review?(echuang)
Assignee

Comment 5

9 months ago
Comment on attachment 9013255 [details] [diff] [review]
Whoops! Too many patches.

Switching to Baku for review, as Eden is a bit busy this week.
Attachment #9013255 - Flags: review?(echuang) → review?(amarchesini)
Attachment #9013255 - Flags: review?(amarchesini) → review+
Assignee

Updated

9 months ago
Keywords: checkin-needed

Comment 6

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df897ffe6e3c
Rename PayerErrorFields to PayerErrors. r=baku
Keywords: checkin-needed
Trying to land this bug on inbound but I'm getting the following error: 

applying 0001-Bug-1495335-Rename-PayerErrorFields-to-PayerErrors.-.patch
patching file browser/components/payments/res/containers/address-form.js
Hunk #1 FAILED at 43
1 out of 1 hunks FAILED -- saving rejects to file browser/components/payments/res/containers/address-form.js.rej
patching file dom/payments/PaymentRequestData.cpp
Hunk #1 FAILED at 491
1 out of 1 hunks FAILED -- saving rejects to file dom/payments/PaymentRequestData.cpp.rej
patching file dom/payments/PaymentResponse.cpp
Hunk #1 FAILED at 340
1 out of 1 hunks FAILED -- saving rejects to file dom/payments/PaymentResponse.cpp.rej
patching file dom/webidl/PaymentRequest.webidl
Hunk #1 FAILED at 73
Hunk #2 FAILED at 91
2 out of 2 hunks FAILED -- saving rejects to file dom/webidl/PaymentRequest.webidl.rej
patching file testing/web-platform/tests/interfaces/payment-request.idl
Hunk #1 FAILED at 48
Hunk #2 FAILED at 168
2 out of 2 hunks FAILED -- saving rejects to file testing/web-platform/tests/interfaces/payment-request.idl.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1495335-Rename-PayerErrorFields-to-PayerErrors.-.patch
Flags: needinfo?(mcaceres)
Ryan already landed it in comment 6
Flags: needinfo?(mcaceres)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13303 for changes under testing/web-platform/tests

Comment 10

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/df897ffe6e3c
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13303
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/bUoVu24jTqGdNLUeG77Svg)
Upstream PR merged
Since the rename happened in the same release as the initial shipment of this dictionary, there is nothing special to do for this bug in terms of documentation. The dictionary and use thereof is being covered in bug 1435161.
You need to log in before you can comment on or make changes to this bug.