Closed Bug 1495335 Opened 2 years ago Closed 2 years ago

Rename `PayerErrorFields` to `PayerErrors`

Categories

(Core :: DOM: Web Payments, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

()

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Being renamed in the spec for consistency.
Working on it...
Assignee: nobody → mcaceres
Severity: normal → trivial
Status: NEW → ASSIGNED
Priority: P3 → P1
Attached patch Rename all the things... (obsolete) — Splinter Review
Attachment #9013210 - Flags: review?(echuang)
Comment on attachment 9013210 [details] [diff] [review]
Rename all the things...

Review of attachment 9013210 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe I misunderstood something, do you attach the correct patch?
I didn't see any renaming code for PayerErrors.
Attachment #9013210 - Attachment is obsolete: true
Attachment #9013210 - Flags: review?(echuang)
Attachment #9013255 - Flags: review?(echuang)
Comment on attachment 9013255 [details] [diff] [review]
Whoops! Too many patches.

Switching to Baku for review, as Eden is a bit busy this week.
Attachment #9013255 - Flags: review?(echuang) → review?(amarchesini)
Attachment #9013255 - Flags: review?(amarchesini) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df897ffe6e3c
Rename PayerErrorFields to PayerErrors. r=baku
Keywords: checkin-needed
Trying to land this bug on inbound but I'm getting the following error: 

applying 0001-Bug-1495335-Rename-PayerErrorFields-to-PayerErrors.-.patch
patching file browser/components/payments/res/containers/address-form.js
Hunk #1 FAILED at 43
1 out of 1 hunks FAILED -- saving rejects to file browser/components/payments/res/containers/address-form.js.rej
patching file dom/payments/PaymentRequestData.cpp
Hunk #1 FAILED at 491
1 out of 1 hunks FAILED -- saving rejects to file dom/payments/PaymentRequestData.cpp.rej
patching file dom/payments/PaymentResponse.cpp
Hunk #1 FAILED at 340
1 out of 1 hunks FAILED -- saving rejects to file dom/payments/PaymentResponse.cpp.rej
patching file dom/webidl/PaymentRequest.webidl
Hunk #1 FAILED at 73
Hunk #2 FAILED at 91
2 out of 2 hunks FAILED -- saving rejects to file dom/webidl/PaymentRequest.webidl.rej
patching file testing/web-platform/tests/interfaces/payment-request.idl
Hunk #1 FAILED at 48
Hunk #2 FAILED at 168
2 out of 2 hunks FAILED -- saving rejects to file testing/web-platform/tests/interfaces/payment-request.idl.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1495335-Rename-PayerErrorFields-to-PayerErrors.-.patch
Flags: needinfo?(mcaceres)
Ryan already landed it in comment 6
Flags: needinfo?(mcaceres)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13303 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/df897ffe6e3c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Since the rename happened in the same release as the initial shipment of this dictionary, there is nothing special to do for this bug in terms of documentation. The dictionary and use thereof is being covered in bug 1435161.
You need to log in before you can comment on or make changes to this bug.