Closed Bug 1495335 Opened 2 years ago Closed 2 years ago
Error Fields` to `Payer Errors`
Being renamed in the spec for consistency.
Priority: -- → P3
Working on it...
Assignee: nobody → mcaceres
Severity: normal → trivial
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 9013210 [details] [diff] [review] Rename all the things... Review of attachment 9013210 [details] [diff] [review]: ----------------------------------------------------------------- Maybe I misunderstood something, do you attach the correct patch? I didn't see any renaming code for PayerErrors.
Comment on attachment 9013255 [details] [diff] [review] Whoops! Too many patches. Switching to Baku for review, as Eden is a bit busy this week.
Attachment #9013255 - Flags: review?(echuang) → review?(amarchesini)
Attachment #9013255 - Flags: review?(amarchesini) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/df897ffe6e3c Rename PayerErrorFields to PayerErrors. r=baku
Trying to land this bug on inbound but I'm getting the following error: applying 0001-Bug-1495335-Rename-PayerErrorFields-to-PayerErrors.-.patch patching file browser/components/payments/res/containers/address-form.js Hunk #1 FAILED at 43 1 out of 1 hunks FAILED -- saving rejects to file browser/components/payments/res/containers/address-form.js.rej patching file dom/payments/PaymentRequestData.cpp Hunk #1 FAILED at 491 1 out of 1 hunks FAILED -- saving rejects to file dom/payments/PaymentRequestData.cpp.rej patching file dom/payments/PaymentResponse.cpp Hunk #1 FAILED at 340 1 out of 1 hunks FAILED -- saving rejects to file dom/payments/PaymentResponse.cpp.rej patching file dom/webidl/PaymentRequest.webidl Hunk #1 FAILED at 73 Hunk #2 FAILED at 91 2 out of 2 hunks FAILED -- saving rejects to file dom/webidl/PaymentRequest.webidl.rej patching file testing/web-platform/tests/interfaces/payment-request.idl Hunk #1 FAILED at 48 Hunk #2 FAILED at 168 2 out of 2 hunks FAILED -- saving rejects to file testing/web-platform/tests/interfaces/payment-request.idl.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh 0001-Bug-1495335-Rename-PayerErrorFields-to-PayerErrors.-.patch
Ryan already landed it in comment 6
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13303 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/13303 * Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/bUoVu24jTqGdNLUeG77Svg)
Upstream PR merged
Since the rename happened in the same release as the initial shipment of this dictionary, there is nothing special to do for this bug in terms of documentation. The dictionary and use thereof is being covered in bug 1435161.
You need to log in before you can comment on or make changes to this bug.