1495335 - Rename `PayerErrorFields` to `PayerErrors`

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, enhancement, P1)

Description

[Marcos Caceres [:marcosc]]

Being renamed in the spec for consistency.

Comment 1

[Marcos Caceres [:marcosc]]

Working on it...

Comment 2

[Marcos Caceres [:marcosc]]

Attachment: Rename all the things...

Comment 3

[Eden Chuang[:edenchuang]]

Comment on attachment 9013210 [details] [diff] [review]
Rename all the things...

Review of attachment 9013210 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe I misunderstood something, do you attach the correct patch?
I didn't see any renaming code for PayerErrors.

Comment 4

[Marcos Caceres [:marcosc]]

Attachment: Whoops! Too many patches.

Comment 5

[Marcos Caceres [:marcosc]]

Comment on attachment 9013255 [details] [diff] [review]
Whoops! Too many patches.

Switching to Baku for review, as Eden is a bit busy this week.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df897ffe6e3c
Rename PayerErrorFields to PayerErrors. r=baku

Comment 7

[Stefan Hindli [:stefan_hindli]]

Trying to land this bug on inbound but I'm getting the following error: 

applying 0001-Bug-1495335-Rename-PayerErrorFields-to-PayerErrors.-.patch
patching file browser/components/payments/res/containers/address-form.js
Hunk #1 FAILED at 43
1 out of 1 hunks FAILED -- saving rejects to file browser/components/payments/res/containers/address-form.js.rej
patching file dom/payments/PaymentRequestData.cpp
Hunk #1 FAILED at 491
1 out of 1 hunks FAILED -- saving rejects to file dom/payments/PaymentRequestData.cpp.rej
patching file dom/payments/PaymentResponse.cpp
Hunk #1 FAILED at 340
1 out of 1 hunks FAILED -- saving rejects to file dom/payments/PaymentResponse.cpp.rej
patching file dom/webidl/PaymentRequest.webidl
Hunk #1 FAILED at 73
Hunk #2 FAILED at 91
2 out of 2 hunks FAILED -- saving rejects to file dom/webidl/PaymentRequest.webidl.rej
patching file testing/web-platform/tests/interfaces/payment-request.idl
Hunk #1 FAILED at 48
Hunk #2 FAILED at 168
2 out of 2 hunks FAILED -- saving rejects to file testing/web-platform/tests/interfaces/payment-request.idl.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1495335-Rename-PayerErrorFields-to-PayerErrors.-.patch

Comment 8

[Matthew N. [:MattN]]

Ryan already landed it in comment 6

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13303 for changes under testing/web-platform/tests

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/df897ffe6e3c

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13303
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/bUoVu24jTqGdNLUeG77Svg)

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 13

[Eric Shepherd [:sheppy]]

Since the rename happened in the same release as the initial shipment of this dictionary, there is nothing special to do for this bug in terms of documentation. The dictionary and use thereof is being covered in bug 1435161.