Closed Bug 1495383 Opened 5 years ago Closed 5 years ago

[remote-dbg-next] Enable worker debugging for usb devices

Categories

(DevTools :: about:debugging, enhancement, P1)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(firefox66 verified, firefox67 verified, firefox68 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox66 --- verified
firefox67 --- verified
firefox68 --- verified

People

(Reporter: daisuke, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Bug 1495383 - Support all debug targets for all runtimes;r=daisuke
47 bytes, text/x-phabricator-request
Details | Review
Bug 1495383 - Test USB runtime in worker remote runtime mochitest;r=daisuke,ola
47 bytes, text/x-phabricator-request
Details | Review
Bug 1495383 - Add Worker, ServiceWorker and Process support on android debugger server;r=daisuke,ochameau
47 bytes, text/x-phabricator-request
Details | Review 
Since we will hide worker debugging for usb devices in bug 1488507 once, we file a bug to enable the debugging.
Moving back to the main meta. m1 is about tab debugging for USB devices, other targets have less priority.
Blocks: remote-debugging-ng
No longer blocks: remote-debugging-ng-m1
Blocks: remote-debugging-ng-m2
No longer blocks: remote-debugging-ng
Priority: P2 → P3
Hmmm I am not sure why this is P3 while the same bug for network locations is P2. Let's fix both at the same time.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P3 → P1
Depends on D15081. I am open to be more conservative and keep the methods
around in case we expect to disable some targets on some runtimes in the future
Attachment #9032659 - Attachment description: Bug 1495383 - Support all debug targets for all runtimes;r=daisuke,ladybenko,ola → Bug 1495383 - Support all debug targets for all runtimes;r=daisuke
Attachment #9032660 - Attachment description: Bug 1495383 - Test USB runtime in worker remote runtime mochitest → Bug 1495383 - Test USB runtime in worker remote runtime mochitest;r=daisuke,ola
I quickly tested on Fennec with the whole stack and I am able to list workers, inspect workers etc...
Could not see any issue at first glance.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/824fafc39762
Add Worker, ServiceWorker and Process support on android debugger server;r=daisuke,ochameau
https://hg.mozilla.org/integration/autoland/rev/26303cb81de7
Support all debug targets for all runtimes;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/e93d25864ea7
Test USB runtime in worker remote runtime mochitest;r=daisuke,Ola

https://hg.mozilla.org/mozilla-central/rev/824fafc39762
https://hg.mozilla.org/mozilla-central/rev/26303cb81de7
https://hg.mozilla.org/mozilla-central/rev/e93d25864ea7

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Verified on Nightly 68.0a1, Beta 67.0b6, release 66.0.2 -on several machines: Windows 10, MAC OS X, Ubuntu 16.04 - on all cases working debugging appears.

Status: RESOLVED → VERIFIED
status-firefox66: fixed → verified
status-firefox67: --- → verified
status-firefox68: --- → verified
You need to log in before you can comment on or make changes to this bug.