1495454 - "Report a problem" control is missing from the Site Information doorhanger

Status: RESOLVED INVALID

(Firefox :: Protections UI, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 63.0b10 build1 (20180927143327)

[Affected platforms]:
- Windows 10 x64 
- Ubuntu 16.04 x64
- macOS 10.12.6

[Steps to reproduce]:
Precondition: Content Blocking must be enabled (set browser.contentblocking.ui.enabled to true and restart the browser) if isn't already.
1. Launch Firefox
2. Open about:preferences#privacy and enable any protection (Slow-Loading Trackers or All Detected Trackers - Always or Third-Party Cookies)
3. Open a random website (that provide blockable content) e.g. https://edition.cnn.com/
- inspect the URL Bar 
- inspect the Site Information doorhanger
- inspect the Web Console logs

[Expected result]:
- if the content for which the protection was enabled is detected and blocked, the Shield icon is displayed in the URL Bar, along with the "Disable Blocking For This Site" and "Report a problem" controls from the Site Information doorhanger

[Actual result]:
- the "Report a problem" control is missing from the Site Information doorhanger, even if blockable content is detected and blocked
- for more details, see the following screenshot https://drive.google.com/file/d/13xumPniyzxtyELz2FdHab7tb7LIaONIh/view?usp=sharing

[Regression range]:
- The issue is reproducible starting with 63.0b10 build1
- Fx 64 is not affected

Comment 1

[Tanvi Vyas[:tanvi]]

This is because browser.contentblocking.reportBreakage.enabled is false by default in beta.  It didn't occur to me that this wasn't conditional on the browser.contentblocking.ui.enabled flag.  We will have to remember to turn on both flags in Beta when we are ready to expose the UI.

Note one issue with turning on browser.contentblocking.reportBreakage.enabled without turning on browser.contentblocking.ui.enabled, is that the description of Report Breakage says "Content Blocking", while the control centerl UI will say "Tracking Protection".  So its probably best we wait to turn on the report breakage button; enable it at the same time we enable content blocking UI.

Can you confirm that with the pref browser.contentblocking.reportBreakage.enabled set to true, this is no longer an issue?

Thanks!

Comment 2

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Tanvi Vyas[:tanvi] from comment #1)

> Can you confirm that with the pref
> browser.contentblocking.reportBreakage.enabled set to true, this is no
> longer an issue?
> 
> Thanks!

I can confirm that flipping browser.contentblocking.reportBreakage.enabled to true, the issue is not reproducible anymore.