1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ursula Sarracini (:ursula)]

In order for Normandy to properly roll out the search shortcuts experiment, we need to migrate the improvesearch.topSiteSearchShortcuts pref to firefox.js so that the value sticks.

Comment 1

[Tim Spurway [:tspurway]]

This bug is specifically required to roll out CFR using Normandy's dynamic rollout capability.  The plan is to pref on US to 100% and follow up with other locales using this pref

Comment 2

[Ursula Sarracini (:ursula)]

Attachment: Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4461

Comment 4

[Ursula Sarracini (:ursula)]

Steps to test that this is still working as intended in Nightly:
1. on a fresh profile, in about:config, ensure the pref browser.newtabpage.activity-stream.improvesearch.topSiteSearchShortcuts is set to true.
2. check that the search shortcuts appear in top sites (they can differ based on locale)
3. open the section context menu for top sites and check that "Add Search Engine" option is present. Ensure this functionality still works as intended
4. in about:config, set the pref browser.newtabpage.activity-stream.improvesearch.topSiteSearchShortcuts to false
5. check that the search shortcuts no appear in top sites, as well as the "Add Search Engine" option is no longer available in section context menu for top sites

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66b90e5af6d1
Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js r=k88hudson

Comment 6

[Kate Hudson :k88hudson]

Comment on attachment 9013398 [details]
Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js

Kate Hudson :k88hudson has approved the revision.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/66b90e5af6d1

Comment 8

[Kate Hudson :k88hudson]

Attachment: Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js For uplift to 63

Comment 9

[Kate Hudson :k88hudson]

Comment on attachment 9014048 [details]
Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js For uplift to 63

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1495517

User impact if declined: If we are unable to roll-out this feature, users will not have access to search shortcuts which will impact revenue and the user's options for ways to search in the browser

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: See comment 4 (https://bugzilla.mozilla.org/show_bug.cgi?id=1495517#c4)

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Small change to preference location, no major code changes

String changes made/needed: None

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/f96306133feaa71b08284808736b5095dbb1d56e
Backport Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js r=k88hudson

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9014048 [details]
Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js For uplift to 63

Blocker to a 63 shield study, uplift approved for 63 beta 12, thanks.

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9014048 [details]
Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js For uplift to 63

Removing uplift approval as the patch caused Bug 1496447, please request approval for the next beta (13) once this is fixed. Thanks.

Comment 13

[Kate Hudson :k88hudson]

Ok, fix is included, thanks.

Comment 14

[Kate Hudson :k88hudson]

Attachment: Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js

Comment 15

[Kate Hudson :k88hudson]

Comment on attachment 9014803 [details]
Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1495517

User impact if declined: If we are unable to roll-out this feature, users will not have access to search shortcuts which will impact revenue and the user's options for ways to search in the browser

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: See comment 4 (https://bugzilla.mozilla.org/show_bug.cgi?id=1495517#c4)

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Small change to preference location, no major code changes

String changes made/needed: None

Comment 16

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9014803 [details]
Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js

Blocker to a 63 shield study, updated patch because of bug  Bug 1496447, uplift approved for 63 beta 13, thanks.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c9f4acecbdf9

Comment 18

[Cristian Craciun]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20181008155858

Verified as fixed on the latest Nightly (v64.0a1 2018-10-10) and on the latest Beta (v63beta13).