Closed Bug 1495562 Opened Last year Closed Last year
Observer List to SVGRendering Observer Set
46 bytes, text/x-phabricator-request
|Details | Review|
There is potential for confusion about the distinction between SVGRenderingObserver sub-classes with names ending in "List", and SVGRenderingObserverList. An instance of the former is an ordered lists for the CSS computed value of a specific property for a specific element, referencing a list of elements that must be applied in the given order, and stored on the *referencing* element's frame. The latter is an unordered set of SVGRenderingObserver instances maintained by a *referenced* element so that it can notify those objects to invalidate their frame when necessary. I think it's useful to make this distinction clear in the naming of the relevant classes (along with related functions) to make it easier to correctly understand what's going on in the code.
Comment on attachment 9013411 [details] Bug 1495562. Rename SVGRenderingObserverList to SVGRenderingObserverSet. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9013411 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ec5d3c12ad4c Rename SVGRenderingObserverList to SVGRenderingObserverSet. r=longsonr
Backout by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1d68c706356c Backed out 2 changesets (bug 1495562, bug 1495554) for crashes on [@ CrashReporter::TerminateHandler()] . CLOSED TREE
Backed out for multiple failures like: 1. Crashes on [@ CrashReporter::TerminateHandler()] Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=202747489&repo=mozilla-inbound&lineNumber=883 2. wpt failures : https://treeherder.mozilla.org/logviewer.html#?job_id=202746623&repo=mozilla-inbound&lineNumber=1025 3. bc failures : https://treeherder.mozilla.org/logviewer.html#?job_id=202746618&repo=mozilla-inbound&lineNumber=1441 4. mochitest crashes on [@ 0x0] : https://treeherder.mozilla.org/logviewer.html#?job_id=202744535&repo=mozilla-inbound&lineNumber=1591
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/d04fa630f0fa Rename SVGRenderingObserverList to SVGRenderingObserverSet. r=longsonr
You need to log in before you can comment on or make changes to this bug.