1495562 - Rename SVGRenderingObserverList to SVGRenderingObserverSet

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

There is potential for confusion about the distinction between SVGRenderingObserver sub-classes with names ending in "List", and SVGRenderingObserverList. An instance of the former is an ordered lists for the CSS computed value of a specific property for a specific element, referencing a list of elements that must be applied in the given order, and stored on the *referencing* element's frame. The latter is an unordered set of SVGRenderingObserver instances maintained by a *referenced* element so that it can notify those objects to invalidate their frame when necessary.

I think it's useful to make this distinction clear in the naming of the relevant classes (along with related functions) to make it easier to correctly understand what's going on in the code.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1495562. Rename SVGRenderingObserverList to SVGRenderingObserverSet. r?longsonr

Comment 2

[Robert Longson [:longsonr]]

Comment on attachment 9013411 [details]
Bug 1495562. Rename SVGRenderingObserverList to SVGRenderingObserverSet. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec5d3c12ad4c
Rename SVGRenderingObserverList to SVGRenderingObserverSet. r=longsonr

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d68c706356c
Backed out 2 changesets (bug 1495562, bug 1495554) for crashes on [@ CrashReporter::TerminateHandler()] . CLOSED TREE

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for multiple failures like:

1. Crashes on [@ CrashReporter::TerminateHandler()]
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=202747489&repo=mozilla-inbound&lineNumber=883

2. wpt failures : https://treeherder.mozilla.org/logviewer.html#?job_id=202746623&repo=mozilla-inbound&lineNumber=1025

3. bc failures : https://treeherder.mozilla.org/logviewer.html#?job_id=202746618&repo=mozilla-inbound&lineNumber=1441

4. mochitest crashes on [@ 0x0] : https://treeherder.mozilla.org/logviewer.html#?job_id=202744535&repo=mozilla-inbound&lineNumber=1591

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d04fa630f0fa
Rename SVGRenderingObserverList to SVGRenderingObserverSet. r=longsonr

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d04fa630f0fa

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/d04fa630f0fa