Closed Bug 1495562 Opened Last year Closed Last year

Rename SVGRenderingObserverList to SVGRenderingObserverSet

Categories

(Core :: SVG, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

There is potential for confusion about the distinction between SVGRenderingObserver sub-classes with names ending in "List", and SVGRenderingObserverList. An instance of the former is an ordered lists for the CSS computed value of a specific property for a specific element, referencing a list of elements that must be applied in the given order, and stored on the *referencing* element's frame. The latter is an unordered set of SVGRenderingObserver instances maintained by a *referenced* element so that it can notify those objects to invalidate their frame when necessary.

I think it's useful to make this distinction clear in the naming of the relevant classes (along with related functions) to make it easier to correctly understand what's going on in the code.
Comment on attachment 9013411 [details]
Bug 1495562. Rename SVGRenderingObserverList to SVGRenderingObserverSet. r?longsonr

Robert Longson [:longsonr] has approved the revision.
Attachment #9013411 - Flags: review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec5d3c12ad4c
Rename SVGRenderingObserverList to SVGRenderingObserverSet. r=longsonr
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d68c706356c
Backed out 2 changesets (bug 1495562, bug 1495554) for crashes on [@ CrashReporter::TerminateHandler()] . CLOSED TREE
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d04fa630f0fa
Rename SVGRenderingObserverList to SVGRenderingObserverSet. r=longsonr
https://hg.mozilla.org/mozilla-central/rev/d04fa630f0fa
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.