1495647 - Animation.playState should incorporate the pending playback rate

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P3)

Description

[Brian Birtles (:birtles)]

I believe this is a spec bug since, for a pending animation, playState should report the playState we are about to enter once we finish pending.

However, for the following code:

  const animation = div.animate({}, 1000);
  animation.updatePlaybackRate(-1);
  animation.play();

We will report 'finished' but after animation.ready resolves we will report 'running'.

As a result of this, when we go to fetch animations for the compositor will not send the animation because Animation::IsPlaying()[1] will return false.

[1] https://searchfox.org/mozilla-central/rev/819cd31a93fd50b7167979607371878c4d6f18e8/dom/animation/EffectCompositor.cpp#118-120

Comment 1

[Brian Birtles (:birtles)]

Spec issue:

  https://github.com/w3c/csswg-drafts/issues/3190

Comment 2

[Brian Birtles (:birtles)]

Attachment: Bug 1495647 - Tidy up tests in play-states.html a little; r?hiro

Comment 3

[Brian Birtles (:birtles)]

Attachment: Bug 1495647 - Use the effective playback rate when calculating the playState; r?hiro

This corresponds to the following change to the Web Animations spec:

  https://github.com/w3c/csswg-drafts/pull/3191/commits/abdebabf7f4af1a77376eadffdf8bc0ff46fc551

Depends on D7573

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15130d3c1c01
Tidy up tests in play-states.html a little; r=hiro
https://hg.mozilla.org/integration/autoland/rev/eb6c2a002b78
Use the effective playback rate when calculating the playState; r=hiro

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13331 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/15130d3c1c01
https://hg.mozilla.org/mozilla-central/rev/eb6c2a002b78

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13331
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/RhEVlySaTViRJFRkMadK2w)