1495738 - Image cache entry should not be reused when Cache-Control header is received

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Andrea Marchesini [:baku]]

I managed to reproduce a race condition where a cached image is used also when the Cache-Control header has been received This happens because we consider valid cache entries, images with no-cache header if used in the same document. This comparison is based on a loadID which is the document's pointer. But that pointer can be reused for another document and we end up exposing a cached image when we should not.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: img.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/135eaacf1dfc
Image cache entry should compare the window ID together with the loadID because the loadID can be a reused pointer, r=aosmond

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/135eaacf1dfc