1495863 - mozrunner does not pass adb path to ADBHost

Status: RESOLVED FIXED

(Testing :: Mozbase, defect, P1)

Description

[Geoff Brown [:gbrown]]

mozrunner has a couple of references to ADBHost() where it passes no parameters. It should at least specify the adb path, if known.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: pass adb path to ADBHost

This code isn't used much currently. I'm trying to use it in bug 1495430 and ran into failures here when ADBHost() could not find adb (it is not in the $PATH). Note that most mozrunner code uses adb via

https://dxr.mozilla.org/mozilla-central/rev/56b988a937689d5599400afa59b72c390b40abf2/testing/mozbase/mozrunner/mozrunner/application.py#105

This change should make it all consistent, so that the ADBHost and ADBAndroid instances use the same adb path.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: pass adb path to ADBHost

Sorry, attached the wrong patch originally.

Comment 3

[Bob Clary [:bc] (inactive)]

Comment on attachment 9013806 [details] [diff] [review]
pass adb path to ADBHost

Review of attachment 9013806 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. r+.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7319f0a16f5
Pass mozrunner adb path when creating ADBHost; r=bc

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b7319f0a16f5

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/b7319f0a16f5