Closed Bug 1495863 Opened 11 months ago Closed 11 months ago

mozrunner does not pass adb path to ADBHost

Categories

(Testing :: Mozbase, defect, P1)

Version 3
defect

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file, 1 obsolete file)

mozrunner has a couple of references to ADBHost() where it passes no parameters. It should at least specify the adb path, if known.
Assignee: nobody → gbrown
Blocks: 1495430
Priority: -- → P1
Attached patch pass adb path to ADBHost (obsolete) — Splinter Review
This code isn't used much currently. I'm trying to use it in bug 1495430 and ran into failures here when ADBHost() could not find adb (it is not in the $PATH). Note that most mozrunner code uses adb via

https://dxr.mozilla.org/mozilla-central/rev/56b988a937689d5599400afa59b72c390b40abf2/testing/mozbase/mozrunner/mozrunner/application.py#105

This change should make it all consistent, so that the ADBHost and ADBAndroid instances use the same adb path.
Attachment #9013802 - Flags: review?(bob)
Sorry, attached the wrong patch originally.
Attachment #9013802 - Attachment is obsolete: true
Attachment #9013802 - Flags: review?(bob)
Attachment #9013806 - Flags: review?(bob)
Comment on attachment 9013806 [details] [diff] [review]
pass adb path to ADBHost

Review of attachment 9013806 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. r+.
Attachment #9013806 - Flags: review?(bob) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7319f0a16f5
Pass mozrunner adb path when creating ADBHost; r=bc
https://hg.mozilla.org/mozilla-central/rev/b7319f0a16f5
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.