Closed
Bug 1495874
Opened 6 years ago
Closed 6 years ago
Don't set win32 subsystem:6.01 on aarch64
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.29 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
We set subsystem:6.01 and get a bunch of warnings from the linker that it's ignoring the unsupported value and using the default instead. These messages are harmless, but noisy. According to MSDN, the minimum is 6.02 on aarch64: https://docs.microsoft.com/en-us/cpp/build/reference/subsystem-specify-subsystem?view=vs-2017
Assignee: nobody → dmajor
Attachment #9014108 -
Flags: review?(nfroyd)
Updated•6 years ago
|
Attachment #9014108 -
Flags: review?(nfroyd) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07aa56ad5aa4 Don't set win32 subsystem:6.01 on aarch64. r=froydnj
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/07aa56ad5aa4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•