Closed Bug 1495874 Opened Last year Closed Last year

Don't set win32 subsystem:6.01 on aarch64

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We set subsystem:6.01 and get a bunch of warnings from the linker that it's ignoring the unsupported value and using the default instead. These messages are harmless, but noisy.

According to MSDN, the minimum is 6.02 on aarch64: https://docs.microsoft.com/en-us/cpp/build/reference/subsystem-specify-subsystem?view=vs-2017
Attached patch arm64-subsystemSplinter Review
Assignee: nobody → dmajor
Attachment #9014108 - Flags: review?(nfroyd)
Attachment #9014108 - Flags: review?(nfroyd) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07aa56ad5aa4
Don't set win32 subsystem:6.01 on aarch64. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/07aa56ad5aa4
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.