1495875 - Fix wpt test multicol-span-none-001-ref.xht

Status: RESOLVED FIXED

(Core :: Layout: Columns, enhancement, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

According to the spec [1], 

  Except for cases where this would cause a column break, content that extends outside column boxes visibly overflows and is not clipped to the column box.

Also, the multi-column container doesn't have any overflow property, so the long <h4> [2] should not be clipped at all. Yet the reference <img> [3] seems to assign the wrong width to test that <h4> should be clipped at column box.

[1] https://drafts.csswg.org/css-multicol-1/#overflow
[2] https://searchfox.org/mozilla-central/rev/6ddb5fb144993fb5de044e2e8d900d7643b98a4d/testing/web-platform/tests/css/css-multicol/multicol-span-none-001.xht#55
[3] https://searchfox.org/mozilla-central/rev/6ddb5fb144993fb5de044e2e8d900d7643b98a4d/testing/web-platform/tests/css/css-multicol/multicol-span-none-001-ref.xht#44

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1495875 - Fix width of black <img> in multicol-span-none-001-ref.xht.

<h4>'s in the test file (multicol-span-none-001-ref.xht) should not be
clipped according to the spec [1]. Fix the width of the reference black
<img>.

260 = 20 (a chararcter's width) * 13

[1] https://drafts.csswg.org/css-multicol-1/#overflow

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/427b3c0f8add
Fix width of black <img> in multicol-span-none-001-ref.xht. r=dbaron

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13326 for changes under testing/web-platform/tests

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/427b3c0f8add

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13326
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/LJlNTiBAQLGTMqmDxSNkOg)

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged