Closed
Bug 1495878
Opened 6 years ago
Closed 6 years ago
disable wasm on aarch64 windows
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: froydnj, Assigned: away)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Apparently somewhere in wasm signal handlers is the first place we crash, so disabling wasm would be a good idea.
As far as I can tell, merely disabling the wasm signal handlers is good enough to avoid the crash in ContextToPC, not sure we need to disable wasm altogether.
Attachment #9014113 -
Flags: review?(luke)
Just so the bugs are linked -- bug 1495879 tracks making this actually work.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9014113 [details] [diff] [review] arm64-WasmSignalHandlers Review of attachment 9014113 [details] [diff] [review]: ----------------------------------------------------------------- FWIW, if EnsureSignalHandlers() returns false, wasm is disabled.
Attachment #9014113 -
Flags: review?(luke) → review+
Hm, rebase failure suggests I should look into how this interacts with bug 1495149...
Ah, the codepaths that lead to the MOZ_CRASH in ContextToPC are still intact, nevermind.
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/463344943de8 Disable wasm signal handlers in the aarch64 Windows build. r=luke
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/463344943de8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•