14959 - floats in tables really thin

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

DESCRIPTION:  Floats in tables just (between 09-25 and 09-26 builds) became
really messed up.  They show up with one word per line in the above test case,
and in some cases the floats are thin to match, but not always.

STEPS TO REPRODUCE:  Load above test case,
http://www.fas.harvard.edu/~dbaron/css/test/sec414

ACTUAL RESULTS:  Floats in tables messed up, as described above.

EXPECTED RESULTS:  Floats in table (second half of page) look just like the
floats before the table (first half of page).

DOES NOT WORK CORRECTLY ON:
 * Linux, viewer, 1999-09-26-09-M11

WORKS CORRECTLY ON:
 * Linux, viewer, 1999-09-25-08-M11
 * Linux, viewer, 1999-09-24-08-M11

ADDITIONAL INFORMATION:
If the second half of the test page looks remotely normal, the bug is fixed, so
I won't bother with a screenshot.

Comment 1

[troy]

Disabling the block resize reflow optimization I added yesterday fixes the
problem.

We need that optimization, so I'll need to figure out what the problem is...

Comment 2

[troy]

The problem was that my optimization wasn't marking enough lines dirty. It turns
out that lines with floaters need to be marked dirty, because it's the reflow of
the placeholder frame that causes the floater to be reflowed