1495910 - telemetry - add an event for recording

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement)

Description

[Jason Laster [:jlast]]

We should add a telemetry event for every time a recording tab is created, this will tell us how often web replay is used in the wild.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

This patch adds telemetry for how often the various menu actions are used.  I verified this locally in about:telemetry (except for devtools.webreplay.stop_recording, which doesn't seem to be exposed in the UI yet), though there isn't test coverage as we don't have any tests operating on the menu items directly.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: data collection request

Data collection request form for the new telemetry counters.

Comment 3

[Chris H-C :chutten]

Comment on attachment 9017881 [details] [diff] [review]
patch

Review of attachment 9017881 [details] [diff] [review]:
-----------------------------------------------------------------

Adding :janerik to review the use of Telemetry.

Comment 4

[Chris H-C :chutten]

Comment on attachment 9017882 [details]
data collection request

Preliminary notes:
For permanent collections you may wish to consider having automated tests. Without a renewal cycle ensuring that someone checks on the probes to make sure stray code changes haven't broken them, untested collections could break without being noticed.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :bhackett.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? 

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for pre-release channels only.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

N/A Permanent collection.

---
Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/040f0e314fcf
Add telemetry for record/replay menu items, r=lsmyth,janerik.

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/040f0e314fcf