Closed Bug 1495984 Opened 7 years ago Closed 7 years ago

nsContentUtils::IsLocalRefURL differs from CssUrl::is_fragment

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

The former skips some control characters before looking for the "#", while the latter just looks at the first character. The Values and Units spec must have changed at some point. The Rust function is the one with the right behavior now.
This fixes the issue that we should no longer be looking for control characters. MozReview-Commit-ID: IBXku42fCrU
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #9017575 - Attachment description: Bug 1495984 - Make css::URLValue::IsLocalRef call into CssUrl::is_fragment. → Bug 1495984 - Make css::URLValue::IsLocalRef call into CssUrlData::is_fragment.
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2920174a5acf Make css::URLValue::IsLocalRef call into CssUrlData::is_fragment. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: