Add sync ipc WebRenderBridgeChild::SendEnsureConnected()

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

8 months ago
In this bug, WebRenderBridgeChild::SendPWebRenderBridgeConstructor() is changed to async ipc. Instread, WebRenderBridgeChild::SendEnsureConnected() is added as sync ipc. It is a prep work for Bug 1492397.
Assignee

Updated

8 months ago
Assignee: nobody → sotaro.ikeda.g
Assignee

Updated

8 months ago
Blocks: 1492397
Comment hidden (obsolete)
Assignee

Updated

8 months ago
Attachment #9013950 - Flags: review?(matt.woodrow)
Comment on attachment 9013950 [details] [diff] [review]
patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected()

Review of attachment 9013950 [details] [diff] [review]:
-----------------------------------------------------------------

Can you tell me more about what the plan going forward?

The patch looks fine, but it's just a different sync call in the same spot. Are you going to call EnsureConnected later?
Assignee

Comment 5

8 months ago
(In reply to Matt Woodrow (:mattwoodrow) from comment #4)
> Comment on attachment 9013950 [details] [diff] [review]
> patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected()
> 
> Review of attachment 9013950 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Can you tell me more about what the plan going forward?
>
> The patch looks fine, but it's just a different sync call in the same spot.
> Are you going to call EnsureConnected later?

The patch just move sync call to EnsureConnected(). It is a preparation for Bug 1492397. In Bug 1492397, EnsureConnected() is going to be removed if possible( only in content process).
Attachment #9013950 - Flags: review?(matt.woodrow) → review+
Assignee

Comment 6

8 months ago
Comment on attachment 9013950 [details] [diff] [review]
patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected()

:froydnj, can you review a change to sync-messages.ini? The patch just move sync call to EnsureConnected(). It is a preparation for Bug 1492397.
Attachment #9013950 - Flags: review?(nfroyd)
Comment on attachment 9013950 [details] [diff] [review]
patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected()

Review of attachment 9013950 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the sync-messages.ini change.
Attachment #9013950 - Flags: review?(nfroyd) → review+

Comment 8

8 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0052f6434876
Add sync ipc WebRenderBridgeChild::SendEnsureConnected() r=mattwoodrow,froydnj

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0052f6434876
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64

Updated

8 months ago
Blocks: 1496825
You need to log in before you can comment on or make changes to this bug.