Closed
Bug 1496003
Opened 6 years ago
Closed 6 years ago
Add sync ipc WebRenderBridgeChild::SendEnsureConnected()
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 1 obsolete file)
|
20.21 KB,
patch
|
mattwoodrow
:
review+
froydnj
:
review+
|
Details | Diff | Splinter Review |
In this bug, WebRenderBridgeChild::SendPWebRenderBridgeConstructor() is changed to async ipc. Instread, WebRenderBridgeChild::SendEnsureConnected() is added as sync ipc. It is a prep work for Bug 1492397.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #9013942 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=203296031&revision=34b3a62f4da3a4c7ab654b1f51d82c2c1da79ad1
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9013950 -
Flags: review?(matt.woodrow)
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9013950 [details] [diff] [review] patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected() Review of attachment 9013950 [details] [diff] [review]: ----------------------------------------------------------------- Can you tell me more about what the plan going forward? The patch looks fine, but it's just a different sync call in the same spot. Are you going to call EnsureConnected later?
|
|
Assignee | |
Comment 5•6 years ago
|
||
(In reply to Matt Woodrow (:mattwoodrow) from comment #4) > Comment on attachment 9013950 [details] [diff] [review] > patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected() > > Review of attachment 9013950 [details] [diff] [review]: > ----------------------------------------------------------------- > > Can you tell me more about what the plan going forward? > > The patch looks fine, but it's just a different sync call in the same spot. > Are you going to call EnsureConnected later? The patch just move sync call to EnsureConnected(). It is a preparation for Bug 1492397. In Bug 1492397, EnsureConnected() is going to be removed if possible( only in content process).
|
|
||
Updated•6 years ago
|
Attachment #9013950 -
Flags: review?(matt.woodrow) → review+
|
|
Assignee | |
Comment 6•6 years ago
|
||
Comment on attachment 9013950 [details] [diff] [review] patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected() :froydnj, can you review a change to sync-messages.ini? The patch just move sync call to EnsureConnected(). It is a preparation for Bug 1492397.
Attachment #9013950 -
Flags: review?(nfroyd)
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9013950 [details] [diff] [review] patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected() Review of attachment 9013950 [details] [diff] [review]: ----------------------------------------------------------------- r=me on the sync-messages.ini change.
Attachment #9013950 -
Flags: review?(nfroyd) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0052f6434876 Add sync ipc WebRenderBridgeChild::SendEnsureConnected() r=mattwoodrow,froydnj
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0052f6434876
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•