Closed Bug 1496003 Opened 7 years ago Closed 7 years ago

Add sync ipc WebRenderBridgeChild::SendEnsureConnected()

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected()
20.21 KB, patch
mattwoodrow
: review+
froydnj
: review+
Details | Diff | Splinter Review
In this bug, WebRenderBridgeChild::SendPWebRenderBridgeConstructor() is changed to async ipc. Instread, WebRenderBridgeChild::SendEnsureConnected() is added as sync ipc. It is a prep work for Bug 1492397.
Assignee: nobody → sotaro.ikeda.g
Blocks: 1492397
Attachment #9013950 - Flags: review?(matt.woodrow)
Comment on attachment 9013950 [details] [diff] [review] patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected() Review of attachment 9013950 [details] [diff] [review]: ----------------------------------------------------------------- Can you tell me more about what the plan going forward? The patch looks fine, but it's just a different sync call in the same spot. Are you going to call EnsureConnected later?
(In reply to Matt Woodrow (:mattwoodrow) from comment #4) > Comment on attachment 9013950 [details] [diff] [review] > patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected() > > Review of attachment 9013950 [details] [diff] [review]: > ----------------------------------------------------------------- > > Can you tell me more about what the plan going forward? > > The patch looks fine, but it's just a different sync call in the same spot. > Are you going to call EnsureConnected later? The patch just move sync call to EnsureConnected(). It is a preparation for Bug 1492397. In Bug 1492397, EnsureConnected() is going to be removed if possible( only in content process).
Attachment #9013950 - Flags: review?(matt.woodrow) → review+
Comment on attachment 9013950 [details] [diff] [review] patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected() :froydnj, can you review a change to sync-messages.ini? The patch just move sync call to EnsureConnected(). It is a preparation for Bug 1492397.
Attachment #9013950 - Flags: review?(nfroyd)
Comment on attachment 9013950 [details] [diff] [review] patch - Add sync ipc WebRenderBridgeChild::SendEnsureConnected() Review of attachment 9013950 [details] [diff] [review]: ----------------------------------------------------------------- r=me on the sync-messages.ini change.
Attachment #9013950 - Flags: review?(nfroyd) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0052f6434876 Add sync ipc WebRenderBridgeChild::SendEnsureConnected() r=mattwoodrow,froydnj
https://hg.mozilla.org/mozilla-central/rev/0052f6434876
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Blocks: 1496825
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: