1496069 - Editing the Saved Addresses shows red fields

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[David Olah]

Attachment: 2018-10-03_1624.png

[Affected versions]: 
Nightly 64.0a1 (2018-10-02), Firefox 63.0b11

[Affected platforms]:
Platforms: Windows 10, Mac OS X, Ubuntu 16.04.

[Preconditions]:

Modify the following prefs via about:config:

- extensions.formautofill.available: on
- extensions.formautofill.creditCards.available: true

[Steps to reproduce]:
1. Go to about:preferences#privacy and search for Forms & Passwords
2. Check the Autofill addresses and click the Saved Addresses button
3. Add a new address with a name
4. Select the same address and hit the Edit button

[Expected result]:
- The uncompleted fields are not highlighted with red border.

[Actual result]:
- The uncompleted fields are highlighted with red border (if you change the name, the rest of the fields remain red but the form can be saved.)

Comment 1

[Matthew N. [:MattN]]

The change at https://hg.mozilla.org/mozilla-central/diff/4b668c00c226/browser/extensions/formautofill/content/manageDialog.js was just wrong. The 4th argument is for a closing callback.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1496069 - Properly pass noValidate to EditAddress and set @novalidate. r?jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d71434f40755
Properly pass noValidate to EditAddress and set @novalidate. r=jaws

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d71434f40755

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 9017400 [details]
Bug 1496069 - Properly pass noValidate to EditAddress and set @novalidate. r?jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1427961

User impact if declined: Users won't be able to save corrections to saved addresses if they are missing some "required" fields

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Ensure that editing a record with some missing fields doesn't show the red outlines and that the save button is enabled.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Fairly straightforward change to pass an additional dialog argument and fix setting the attribute

String changes made/needed: None

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9017400 [details]
Bug 1496069 - Properly pass noValidate to EditAddress and set @novalidate. r?jaws

Resetting the uplift request flag for approval‑mozilla‑release as we are now in the release candidates phase
Matt, are the flag changes needed to reproduce the issue in comment #0 a supported scenario on our release channel or would one hit this bug only if he changed values in about:config?

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: 

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): 

String changes made/needed:

Comment 7

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and on Ubuntu 16.04 x64.

Comment 8

[Matthew N. [:MattN]]

(In reply to Pascal Chevrel:pascalc from comment #6)
> Matt, are the flag changes needed to reproduce the issue in comment #0 a
> supported scenario on our release channel or would one hit this bug only if
> he changed values in about:config?

Neither of those prefs need to be changed to hit this bug in en-US builds for users in the US where Address Autofill is enabled by default.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9017400 [details]
Bug 1496069 - Properly pass noValidate to EditAddress and set @novalidate. r?jaws

Taking for RC2 as this is a visible UI regression for a feature affecting our top locale and it was verified as fixed on Nightly.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/c023e8e06880

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This got backed out after there were conflicts applying the patch and there were eslint and browser-chrome failures after resolving:

https://hg.mozilla.org/releases/mozilla-release/rev/e986b9e437b6859ca180861e5fa265081b2d12cc

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-release&resultStatus=usercancel%2Crunnable%2Ctestfailed%2Cbusted%2Cexception%2Cretry&group_state=expanded&selectedJob=206369237&revision=8c489cac4a10cb54027647e64cfd08cff46bef37

Comment 12

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-release/rev/b9768ea75a5d

Comment 13

[Matthew N. [:MattN]]

eslint and autofill tests passed locally.

Comment 14

[Hani Yacoub, Desktop QA]

Build ID: 20181018182531
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Verified as fixed on Firefox 63.0 RC build 2 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 16.04 x64.