Closed Bug 1496114 Opened Last year Closed Last year
Permafailing wpt failures on /feature-policy/payment-allowed-by-feature-policy-attribute-redirect-on-load
.https .sub .html when Gecko 64 merges to Beta on 2018-10-15
Central as Beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8242b1f0795a4aa56ac7f54ed4396dbaa842bc7&selectedJob=203112747 Failure log: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=e8242b1f0795a4aa56ac7f54ed4396dbaa842bc7&selectedJob=203112747
This appears to be from bug 1495359. Andrea can you please take a look?
Depends on: 1495359
No longer depends on: 1495359
Summary: Permafailing wpt failures on /feature-policy/payment-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html → Permafailing wpt failures on /feature-policy/payment-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html when Gecko 64 merges to Beta on 2018-10-15
The problem is that payment API is completely disabled in nightly. This means we cannot enable it by pref in order to run those WPTs: https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/dom/payments/PaymentRequest.cpp#63-68 I can submit a patch to change this code, or I can disable the tests for beta.
Assignee: nobody → amarchesini
Attachment #9014094 - Flags: review?(mcaceres)
Comment on attachment 9014094 [details] [diff] [review] pref.patch Review of attachment 9014094 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #9014094 - Flags: review?(mcaceres) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/474f3df15a58 PaymentRequest CTOR is controlled by pref, r=marcosc
We should uplift this patch when in central.
(In reply to Andrea Marchesini [:baku] from comment #7) > We should uplift this patch when in central. The beta simulations are done with the good in the central tree. The issue should be gone in today's beta simulations. Do you want it uplifted for other reasons? If yes, please request beta approval.
QA Contact: overholt
Looks like this issue was not fixed, is still present on beta sims. https://treeherder.mozilla.org/logviewer.html#?job_id=204498399&repo=try&lineNumber=13379
Baku, since UI code is not packaged into the Beta, when running tests, the lack of UI introduces errors/crashes. So I would like to check in the patch on bug 1495301 to avoid crashing tests.
Sounds good to me.
Status: REOPENED → RESOLVED
Closed: Last year → Last year
Resolution: --- → DUPLICATE
Duplicate of bug: 1495301
You need to log in before you can comment on or make changes to this bug.