1496114 - Permafailing wpt failures on /feature-policy/payment-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html when Gecko 64 merges to Beta on 2018-10-15

Status: RESOLVED DUPLICATE of bug 1495301

(Core :: DOM: Core & HTML, defect, P2)

Description

[Tiberius Oros[:tiberius_oros]]

Central as Beta:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8242b1f0795a4aa56ac7f54ed4396dbaa842bc7&selectedJob=203112747

Failure log: 
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=e8242b1f0795a4aa56ac7f54ed4396dbaa842bc7&selectedJob=203112747

Comment 1

[Andreea Pavel [:apavel]]

This appears to be from bug 1495359. 

Andrea can you please take a look?

Comment 2

[Andrea Marchesini [:baku]]

The problem is that payment API is completely disabled in nightly. This means we cannot enable it by pref in order to run those WPTs:

https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/dom/payments/PaymentRequest.cpp#63-68

I can submit a patch to change this code, or I can disable the tests for beta.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: pref.patch

Comment 4

[Marcos Caceres [:marcosc]]

Comment on attachment 9014094 [details] [diff] [review]
pref.patch

Review of attachment 9014094 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Intermittent Failures Robot]

40 failures in 465 pushes (0.086 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 40

Platform breakdown:
* linux32-devedition: 2
* windows7-32: 3
* macosx64-devedition: 2
* linux64-devedition: 2
* linux64-nightly: 2
* osx-10-10: 4
* linux64-qr: 4
* windows10-64-nightly: 2
* linux32: 4
* macosx64-nightly: 2
* windows7-32-nightly: 2
* windows10-64-devedition: 1
* linux64: 6
* linux32-nightly: 1
* windows10-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496114&startday=2018-10-03&endday=2018-10-03&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/474f3df15a58
PaymentRequest CTOR is controlled by pref, r=marcosc

Comment 7

[Andrea Marchesini [:baku]]

We should uplift this patch when in central.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/474f3df15a58

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Andrea Marchesini [:baku] from comment #7)
> We should uplift this patch when in central.
The beta simulations are done with the good in the central tree. The issue should be gone in today's beta simulations. Do you want it uplifted for other reasons? If yes, please request beta approval.

Comment 10

[Intermittent Failures Robot]

40 failures in 2708 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 40

Platform breakdown:
* linux64-qr: 4
* windows10-64: 3
* linux32: 4
* linux64-nightly: 2
* windows7-32-nightly: 2
* macosx64-nightly: 2
* osx-10-10: 4
* macosx64-devedition: 2
* windows10-64-nightly: 2
* linux64-devedition: 2
* windows10-64-devedition: 1
* windows7-32: 3
* linux32-nightly: 1
* linux32-devedition: 2
* linux64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496114&startday=2018-10-01&endday=2018-10-07&tree=all

Comment 11

[Dorel Luca [:dluca]]

Looks like this issue was not fixed, is still present on beta sims.

https://treeherder.mozilla.org/logviewer.html#?job_id=204498399&repo=try&lineNumber=13379

Comment 12

[Eden Chuang[:edenchuang]]

Baku, since UI code is not packaged into the Beta, when running tests, the lack of UI introduces errors/crashes. So I would like to check in the patch on bug 1495301 to avoid crashing tests.

Comment 13

[Andrea Marchesini [:baku]]

Sounds good to me.

Comment 15

[Intermittent Failures Robot]

3 failures in 2740 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 3

Platform breakdown:
* linux32: 1
* linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496114&startday=2018-10-08&endday=2018-10-14&tree=all