Closed Bug 1496193 Opened Last year Closed 8 months ago

Remove unused datepicker[type="grid"] selector from xul.css

Categories

(Toolkit :: XUL Widgets, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: ntim, Assigned: trushita, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

The datepicker binding has been removed from m-c, but that selector is still there.
Summary: Remove unused selector from xul.css → Remove unused datepicker[type="grid"] selector from xul.css
Component: Themes → XUL Widgets
Priority: -- → P5
Mentor: bgrinstead
Keywords: good-first-bug
I am new here . I want to work on this bug . Looking for mentorship to get started. Thank you.
I am new here . I want to work on this bug . Looking for mentorship to get started. Thank you.
Flags: needinfo?(bgrinstead)
(In reply to shanudjn from comment #2)
> I am new here . I want to work on this bug . Looking for mentorship to get
> started. Thank you.

Hi shanudjn, see the following instructions for doing a Firefox build: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build. You can use "artifact" builds for this fix which should make the build a bit easier (since it's only changing CSS.

Once you get it pulled down and built, here are instructions for creating and submitting a patch: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch.

Finally, once you've done the above the "easy" part will be to fix the bug, which requires moving this single line of code: https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77.

Good luck, and let me know if you bump into issues with the guides above.
Flags: needinfo?(bgrinstead)
(In reply to Brian Grinstead [:bgrins] from comment #3)
> (In reply to shanudjn from comment #2)
> > I am new here . I want to work on this bug . Looking for mentorship to get
> > started. Thank you.
> 
> Hi shanudjn, see the following instructions for doing a Firefox build:
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Simple_Firefox_build. You can use "artifact" builds for
> this fix which should make the build a bit easier (since it's only changing
> CSS.
> 
> Once you get it pulled down and built, here are instructions for creating
> and submitting a patch:
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> How_to_Submit_a_Patch.
> 
> Finally, once you've done the above the "easy" part will be to fix the bug,
> which requires moving this single line of code:
> https://searchfox.org/mozilla-central/rev/
> 3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77.
> 
> Good luck, and let me know if you bump into issues with the guides above.

Getting down with Firefox build. Will connect with you as soon as the built finishes and before moving forward with fixing the bug.
(In reply to shanudjn from comment #4)
> (In reply to Brian Grinstead [:bgrins] from comment #3)
> > (In reply to shanudjn from comment #2)
> > > I am new here . I want to work on this bug . Looking for mentorship to get
> > > started. Thank you.
> > 
> > Hi shanudjn, see the following instructions for doing a Firefox build:
> > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> > Build_Instructions/Simple_Firefox_build. You can use "artifact" builds for
> > this fix which should make the build a bit easier (since it's only changing
> > CSS.
> > 
> > Once you get it pulled down and built, here are instructions for creating
> > and submitting a patch:
> > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> > How_to_Submit_a_Patch.
> > 
> > Finally, once you've done the above the "easy" part will be to fix the bug,
> > which requires moving this single line of code:
> > https://searchfox.org/mozilla-central/rev/
> > 3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77.
> > 
> > Good luck, and let me know if you bump into issues with the guides above.
> 
> Getting down with Firefox build. Will connect with you as soon as the built
> finishes and before moving forward with fixing the bug.

I have completed building mozilla.Can you please guide me through what is to be done next. I have gone through the link of submitiing a patch . That is where I am stuck right now.
And clicking on this link shows nothing except a "bad revision" method.
I would like to work on this bug. can i proceed ?
(In reply to chandranvishwaak from comment #9)
> I would like to work on this bug. can i proceed ?

Actually I am working on it. If you don't mind can you look for some other bug. As I am just starting , it be really helpful of you to let me work on it and get a hang of how open source contributing works. Thank you.
Assignee: nobody → shanudjn
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #8)
> The correct link is in comment 3:
> https://searchfox.org/mozilla-central/rev/
> 3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

Sir I have build it once and now have removed the datepicker[type="grid"] selector from xul.css . So what should I do next , do I need to submit the patch now . If that is the case should I carry on with reading the how to sublit a patch from the link provided by you in the previous messages.
(In reply to Md Shahazad Uddin from comment #11)
> (In reply to Tim Nguyen :ntim (please use needinfo?) from comment #8)
> > The correct link is in comment 3:
> > https://searchfox.org/mozilla-central/rev/
> > 3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77
> 
> Sir I have build it once and now have removed the datepicker[type="grid"]
> selector from xul.css . So what should I do next , do I need to submit the
> patch now . If that is the case should I carry on with reading the how to
> sublit a patch from the link provided by you in the previous messages.

Yes, you should follow the "Creating a patch" and "Submitting the patch" steps from https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

(In reply to Tim Nguyen :ntim from comment #12)

(In reply to Md Shahazad Uddin from comment #11)

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #8)

The correct link is in comment 3:
https://searchfox.org/mozilla-central/rev/
3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

Sir I have build it once and now have removed the datepicker[type="grid"]
selector from xul.css . So what should I do next , do I need to submit the
patch now . If that is the case should I carry on with reading the how to
sublit a patch from the link provided by you in the previous messages.

Yes, you should follow the "Creating a patch" and "Submitting the patch"
steps from
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
How_to_Submit_a_Patch

Sir, I was taking my semester exams so could not work on it. Would like to get back on it. But I have forgotten the password of the previous account which I had. Could you please assign the bug to this account . Thank you

(In reply to Tim Nguyen :ntim from comment #12)

(In reply to Md Shahazad Uddin from comment #11)

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #8)

The correct link is in comment 3:
https://searchfox.org/mozilla-central/rev/
3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

Sir I have build it once and now have removed the datepicker[type="grid"]
selector from xul.css . So what should I do next , do I need to submit the
patch now . If that is the case should I carry on with reading the how to
sublit a patch from the link provided by you in the previous messages.

Yes, you should follow the "Creating a patch" and "Submitting the patch"
steps from
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
How_to_Submit_a_Patch

Sir, I was taking my semester exams so could not work on it. Would like to get back on it. But I have forgotten the password of the previous account which I had. Could you please assign the bug to this account . Thank you

(In reply to SHAHAZAD UDDIN from comment #14)

Sir, I was taking my semester exams so could not work on it. Would like to get back on it. But I have forgotten the password of the previous account which I had. Could you please assign the bug to this account . Thank you

Done :)

Assignee: shanudjn → mdshahazaduddin

Hey, any update on this ?

Flags: needinfo?(mdshahazaduddin)

Hi, Can I work on this if no one is working?

Flags: needinfo?(ntim.bugs)

Yeah, please go ahead :)

Assignee: mdshahazaduddin → trushita
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(mdshahazaduddin)

Thanks

I want to submit the path. who should i put in review?

Flags: needinfo?(bgrinstead)

(In reply to trushita from comment #20)

I want to submit the path. who should i put in review?

sorry, I mean patch

(In reply to trushita from comment #20)

I want to submit the path. who should i put in review?

You can set me to review (or just push the patch up and I'll take a look).

Flags: needinfo?(bgrinstead)

Removed unused datepicker[type=grid] selector

Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e80e950b1e6
Remove unused datepicker[type=grid] selector r=bgrins
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.