1496193 - Remove unused datepicker[type="grid"] selector from xul.css

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement, P5)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

The datepicker binding has been removed from m-c, but that selector is still there.

Comment 1

[Md Shahazad Uddin]

I am new here . I want to work on this bug . Looking for mentorship to get started. Thank you.

Comment 2

[Md Shahazad Uddin]

I am new here . I want to work on this bug . Looking for mentorship to get started. Thank you.

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to shanudjn from comment #2)
> I am new here . I want to work on this bug . Looking for mentorship to get
> started. Thank you.

Hi shanudjn, see the following instructions for doing a Firefox build: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build. You can use "artifact" builds for this fix which should make the build a bit easier (since it's only changing CSS.

Once you get it pulled down and built, here are instructions for creating and submitting a patch: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch.

Finally, once you've done the above the "easy" part will be to fix the bug, which requires moving this single line of code: https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77.

Good luck, and let me know if you bump into issues with the guides above.

Comment 4

[Md Shahazad Uddin]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> (In reply to shanudjn from comment #2)
> > I am new here . I want to work on this bug . Looking for mentorship to get
> > started. Thank you.
> 
> Hi shanudjn, see the following instructions for doing a Firefox build:
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Simple_Firefox_build. You can use "artifact" builds for
> this fix which should make the build a bit easier (since it's only changing
> CSS.
> 
> Once you get it pulled down and built, here are instructions for creating
> and submitting a patch:
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> How_to_Submit_a_Patch.
> 
> Finally, once you've done the above the "easy" part will be to fix the bug,
> which requires moving this single line of code:
> https://searchfox.org/mozilla-central/rev/
> 3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77.
> 
> Good luck, and let me know if you bump into issues with the guides above.

Getting down with Firefox build. Will connect with you as soon as the built finishes and before moving forward with fixing the bug.

Comment 5

[Md Shahazad Uddin]

(In reply to shanudjn from comment #4)
> (In reply to Brian Grinstead [:bgrins] from comment #3)
> > (In reply to shanudjn from comment #2)
> > > I am new here . I want to work on this bug . Looking for mentorship to get
> > > started. Thank you.
> > 
> > Hi shanudjn, see the following instructions for doing a Firefox build:
> > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> > Build_Instructions/Simple_Firefox_build. You can use "artifact" builds for
> > this fix which should make the build a bit easier (since it's only changing
> > CSS.
> > 
> > Once you get it pulled down and built, here are instructions for creating
> > and submitting a patch:
> > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> > How_to_Submit_a_Patch.
> > 
> > Finally, once you've done the above the "easy" part will be to fix the bug,
> > which requires moving this single line of code:
> > https://searchfox.org/mozilla-central/rev/
> > 3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77.
> > 
> > Good luck, and let me know if you bump into issues with the guides above.
> 
> Getting down with Firefox build. Will connect with you as soon as the built
> finishes and before moving forward with fixing the bug.

I have completed building mozilla.Can you please guide me through what is to be done next. I have gone through the link of submitiing a patch . That is where I am stuck right now.

Comment 6

[Md Shahazad Uddin]

And clicking on this link shows nothing except a "bad revision" method.

Comment 7

[Md Shahazad Uddin]

 https://searchfox.org/mozilla-central/rev/

Comment 8

[Tim Nguyen :ntim]

The correct link is in comment 3: https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

Comment 9

[chandranvishwaak]

I would like to work on this bug. can i proceed ?

Comment 10

[Md Shahazad Uddin]

(In reply to chandranvishwaak from comment #9)
> I would like to work on this bug. can i proceed ?

Actually I am working on it. If you don't mind can you look for some other bug. As I am just starting , it be really helpful of you to let me work on it and get a hang of how open source contributing works. Thank you.

Comment 11

[Md Shahazad Uddin]

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #8)
> The correct link is in comment 3:
> https://searchfox.org/mozilla-central/rev/
> 3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

Sir I have build it once and now have removed the datepicker[type="grid"] selector from xul.css . So what should I do next , do I need to submit the patch now . If that is the case should I carry on with reading the how to sublit a patch from the link provided by you in the previous messages.

Comment 12

[Tim Nguyen :ntim]

(In reply to Md Shahazad Uddin from comment #11)
> (In reply to Tim Nguyen :ntim (please use needinfo?) from comment #8)
> > The correct link is in comment 3:
> > https://searchfox.org/mozilla-central/rev/
> > 3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77
> 
> Sir I have build it once and now have removed the datepicker[type="grid"]
> selector from xul.css . So what should I do next , do I need to submit the
> patch now . If that is the case should I carry on with reading the how to
> sublit a patch from the link provided by you in the previous messages.

Yes, you should follow the "Creating a patch" and "Submitting the patch" steps from https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Comment 13

[SHAHAZAD UDDIN]

(In reply to Tim Nguyen :ntim from comment #12)

(In reply to Md Shahazad Uddin from comment #11)

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #8)

The correct link is in comment 3:
https://searchfox.org/mozilla-central/rev/
3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

Sir I have build it once and now have removed the datepicker[type="grid"]
selector from xul.css . So what should I do next , do I need to submit the
patch now . If that is the case should I carry on with reading the how to
sublit a patch from the link provided by you in the previous messages.

Yes, you should follow the "Creating a patch" and "Submitting the patch"
steps from
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
How_to_Submit_a_Patch

Sir, I was taking my semester exams so could not work on it. Would like to get back on it. But I have forgotten the password of the previous account which I had. Could you please assign the bug to this account . Thank you

Comment 14

[SHAHAZAD UDDIN]

(In reply to Tim Nguyen :ntim from comment #12)

(In reply to Md Shahazad Uddin from comment #11)

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #8)

The correct link is in comment 3:
https://searchfox.org/mozilla-central/rev/
3c85ea2f8700ab17e38b82d77cd44644b4dae703/toolkit/content/xul.css#77

Sir I have build it once and now have removed the datepicker[type="grid"]
selector from xul.css . So what should I do next , do I need to submit the
patch now . If that is the case should I carry on with reading the how to
sublit a patch from the link provided by you in the previous messages.

Yes, you should follow the "Creating a patch" and "Submitting the patch"
steps from
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
How_to_Submit_a_Patch

Sir, I was taking my semester exams so could not work on it. Would like to get back on it. But I have forgotten the password of the previous account which I had. Could you please assign the bug to this account . Thank you

Comment 15

[Tim Nguyen :ntim]

(In reply to SHAHAZAD UDDIN from comment #14)

Sir, I was taking my semester exams so could not work on it. Would like to get back on it. But I have forgotten the password of the previous account which I had. Could you please assign the bug to this account . Thank you

Done :)

Comment 16

[Tim Nguyen :ntim]

Hey, any update on this ?

Comment 17

[trushita]

Hi, Can I work on this if no one is working?

Comment 18

[Tim Nguyen :ntim]

Yeah, please go ahead :)

Comment 19

[trushita]

Thanks

Comment 20

[trushita]

I want to submit the path. who should i put in review?

Comment 21

[trushita]

(In reply to trushita from comment #20)

I want to submit the path. who should i put in review?

sorry, I mean patch

Comment 22

[Brian Grinstead [:bgrins]]

(In reply to trushita from comment #20)

I want to submit the path. who should i put in review?

You can set me to review (or just push the patch up and I'll take a look).

Comment 23

[trushita]

Attachment: Bug 1496193: Remove unused datepicker[type=grid] selector

Removed unused datepicker[type=grid] selector

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e80e950b1e6
Remove unused datepicker[type=grid] selector r=bgrins

Comment 25

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4e80e950b1e6

Comment 26

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/4e80e950b1e6c5e3c6cd638d55747516bb1e7198
Bug 1496193: Remove unused datepicker[type=grid] selector r=bgrins