1496222 - ffvp9 fails to decode some VP9 files

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Jean-Yves Avenard [:jya]]

Those files:
https://jyavenard.github.io/htmltests/mediatest/webm/vp9/yuv420p12.webm
https://jyavenard.github.io/htmltests/mediatest/webm/vp9/yuv422p10.webm
https://jyavenard.github.io/htmltests/mediatest/webm/vp9/yuv422p12.webm

Fail to play with ffmpeg.

They are made of a single frame.

That frame is passed to avcodec_decode_video2 (https://searchfox.org/mozilla-central/source/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp#219)
it will use all bytes, but doesn't return any frame.

Then the decoder is drained, feeding null/zero to avcodec_decode_video2 which returns -1 

Draining should never return -1.

Comment 1

[Jean-Yves Avenard [:jya]]

If I disable MT decoding (by setting mCodecContext->thread_count = 1)
then the first avcodec_decode_video2 returns 1

Comment 2

[Jean-Yves Avenard [:jya]]

It's our code.
https://searchfox.org/mozilla-central/source/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp#50

doesn't support 422 nor 420p12

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1496222 - Add missing pixel format in FFmpeg decoder

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44cc1c10c530
Add missing pixel format in FFmpeg decoder r=padenot

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/44cc1c10c530