1496245 - RTCPeerConnection createOffer generates malformed sdp after rollback

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Manjesh Malavalli]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Steps to reproduce:

Run https://jsfiddle.net/03ykx5q1/ in a Firefox tab.
See console for results.


Actual results:

The generated offer is malformed due to the presence of this media section:

m=audio 0 DTLS/SCTP 0
c=IN IP4 0.0.0.0
a=inactive
a=mid:application0
a=rtpmap:0 PCMU/8000


Expected results:

The generated offer should not be malformed.

Comment 1

[Nils Ohlmeier [:drno]]

This looks pretty messed up in the sense that it says m=audio, but DTLS/SCTP and mid:application0.

Byron, could you please have a quick initial look to check how bad this is?

Comment 2

[Byron Campen [:bwc]]

Huh, weird. I'll look into it.

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5242bfc683012c0d60c13422bef0d7f73ba1772

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=83d3429e9edf2040caa8afc59011c15dcf44bc2a

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b49fc0a34f2efb2eece2651266a2a03abfbe0ce5

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e27d61ec5cd0a24001b2e511488e3b26751101fc

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46723d1cd0f5d74bfe53d71232ddd36ed5aafe26

Comment 8

[Byron Campen [:bwc]]

Attachment: Bug 1496245: Fix bugs where transceivers could be associated with m-sections of another type.

Bug 1496245 - Part 1: Allow SRD(offer) to stomp un-negotiated level mappings on our transceivers.

Bug 1496245 - Part 2: Don't create extra datachannel transceivers, just reuse (and possibly re-enable) the one we have.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7641a700ff6
Fix bugs where transceivers could be associated with m-sections of another type. r=mjf,jib

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13723 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d7641a700ff6

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift or can it ride the trains?

Comment 15

[Byron Campen [:bwc]]

I think we can let this ride the trains. It is a pretty rare corner case.