1496275 - Fix wpt test multicol-span-all-margin-bottom-001-ref.xht

Status: RESOLVED FIXED

(Core :: Layout: Columns, defect, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Per example in the spec https://drafts.csswg.org/css-multicol-1/#column-span

  ... the bottom margin of the second spanner does not collapse with the top
  margin of the subsequent element.

Likewise, in the test file multicol-span-all-margin-bottom-001.xht [1], the
bottom margin of the black spanner <h4> should not collapse with the top
margin of the orange non-spanner <h4>.

Again, the test matches the old version of the spec https://drafts.csswg.org/css-multicol/#changes-from-20110412

[1] https://searchfox.org/mozilla-central/source/testing/web-platform/tests/css/css-multicol/multicol-span-all-margin-bottom-001.xht

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1496275 - Fix wpt test multicol-span-all-margin-bottom-001-ref.xht.

Per example in the spec https://drafts.csswg.org/css-multicol-1/#column-span

  ... the bottom margin of the second spanner does not collapse with the top
  margin of the subsequent element.

Likewise, in the test file multicol-span-all-margin-bottom-001.xht, the
bottom margin of the black spanner <h4> should not collapse with the top
margin of the orange non-spanner <h4>.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Reminder to file a bug for Chromium per https://phabricator.services.mozilla.com/D7670#179118.

Also, the patch has been updated so that it doesn't depend on bug 1421105.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f3ac50f1ce9
Fix wpt test multicol-span-all-margin-bottom-001-ref.xht. r=dbaron

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2f3ac50f1ce9

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13395 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13395
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/Zh3pR8pjQhKdE_f2hvtXuA)

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

(In reply to Ting-Yu Lin [:TYLin] (UTC-7) from comment #2)
> Reminder to file a bug for Chromium per
> https://phabricator.services.mozilla.com/D7670#179118.

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=892817