Fix wpt test multicol-span-all-margin-bottom-001-ref.xht

RESOLVED FIXED in Firefox 64

Status

()

defect
P3
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

(Blocks 1 bug)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Per example in the spec https://drafts.csswg.org/css-multicol-1/#column-span

  ... the bottom margin of the second spanner does not collapse with the top
  margin of the subsequent element.

Likewise, in the test file multicol-span-all-margin-bottom-001.xht [1], the
bottom margin of the black spanner <h4> should not collapse with the top
margin of the orange non-spanner <h4>.

Again, the test matches the old version of the spec https://drafts.csswg.org/css-multicol/#changes-from-20110412

[1] https://searchfox.org/mozilla-central/source/testing/web-platform/tests/css/css-multicol/multicol-span-all-margin-bottom-001.xht
Per example in the spec https://drafts.csswg.org/css-multicol-1/#column-span

  ... the bottom margin of the second spanner does not collapse with the top
  margin of the subsequent element.

Likewise, in the test file multicol-span-all-margin-bottom-001.xht, the
bottom margin of the black spanner <h4> should not collapse with the top
margin of the orange non-spanner <h4>.
Depends on: 1421105
Reminder to file a bug for Chromium per https://phabricator.services.mozilla.com/D7670#179118.

Also, the patch has been updated so that it doesn't depend on bug 1421105.
No longer depends on: 1421105
Flags: needinfo?(aethanyc)
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2f3ac50f1ce9
Fix wpt test multicol-span-all-margin-bottom-001-ref.xht. r=dbaron
https://hg.mozilla.org/mozilla-central/rev/2f3ac50f1ce9
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13395 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13395
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/Zh3pR8pjQhKdE_f2hvtXuA)
Upstream PR merged
(In reply to Ting-Yu Lin [:TYLin] (UTC-7) from comment #2)
> Reminder to file a bug for Chromium per
> https://phabricator.services.mozilla.com/D7670#179118.

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=892817
Flags: needinfo?(aethanyc)
You need to log in before you can comment on or make changes to this bug.