1496377 - test_mediarecorder_state_transition.html is not being run in tests (and fails)

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect, P3)

Description

[Mark Banner (:standard8)]

I picked this up from #introduction on irc from talking with :kbumsik about an issue running a test.

It seems that dom/media/test/test_mediarecorder_state_transition.html is never run, because it is not listed in mochitest.ini.

I did a bit of digging, and back in 2013 when we transitioned from Makefile.in to mochitest.ini, this file got missed:

https://hg.mozilla.org/mozilla-central/rev/7f083546aa95

Attempting to enable it currently shows a series of failures:

dom/media/test/test_mediarecorder_state_transition.html
  FAIL Failed transitions for start,pause,pause
    runStateTransitionTests@dom/media/test/test_mediarecorder_state_transition.html:130:9
    startTest/element.oncanplaythrough@dom/media/test/test_mediarecorder_state_transition.html:160:5
    EventHandlerNonNull*startTest@dom/media/test/test_mediarecorder_state_transition.html:158:3
    MediaTestManager/this.nextTest@dom/media/test/manifest.js:1833:7
    MediaTestManager/this.runTests/<@dom/media/test/manifest.js:1753:7
  FAIL Failed transitions for start,pause,requestData
    runStateTransitionTests@dom/media/test/test_mediarecorder_state_transition.html:130:9
    startTest/element.oncanplaythrough@dom/media/test/test_mediarecorder_state_transition.html:160:5
    EventHandlerNonNull*startTest@dom/media/test/test_mediarecorder_state_transition.html:158:3
    MediaTestManager/this.nextTest@dom/media/test/manifest.js:1833:7
    MediaTestManager/this.runTests/<@dom/media/test/manifest.js:1753:7
  FAIL No InvalidStateError for start,pause,resume
    runStateTransitionTests@dom/media/test/test_mediarecorder_state_transition.html:136:9
    startTest/element.oncanplaythrough@dom/media/test/test_mediarecorder_state_transition.html:160:5
    EventHandlerNonNull*startTest@dom/media/test/test_mediarecorder_state_transition.html:158:3
    MediaTestManager/this.nextTest@dom/media/test/manifest.js:1833:7
    MediaTestManager/this.runTests/<@dom/media/test/manifest.js:1753:7
  FAIL No InvalidStateError for start,pause,resume with timeslice 200
    runStateTransitionTests@dom/media/test/test_mediarecorder_state_transition.html:136:9
    startTest/element.oncanplaythrough@dom/media/test/test_mediarecorder_state_transition.html:160:5
    EventHandlerNonNull*startTest@dom/media/test/test_mediarecorder_state_transition.html:158:3
    MediaTestManager/this.nextTest@dom/media/test/manifest.js:1833:7
    MediaTestManager/this.runTests/<@dom/media/test/manifest.js:1753:7

Comment 1

[Mark Banner (:standard8)]

Note: bug 1496383 may / may not be related.

Comment 2

[Bumsik Kim]

I uploaded a patch for bug 1496383. Apart from the test result, I think the test cases written in test_mediarecorder_state_transition.html are quite incorrect. I can correct them if anyone assign me to upload a patch.

Comment 3

[Mark Banner (:standard8)]

Bumsik: You should be able to upload the patch without being assigned. I don't know if in this case it might be better to do the patch + test together, in any case I can assign you to this one.

Comment 4

[Bumsik Kim]

Attachment: Bug 1496377 - Fix and add test_mediarecorder_state_transition.html in tests. r=standard8

This resolves two problems:

1. test_mediarecorder_state_transition.html was not in mochitest.ini.
2. The test set in the file has some wrong test cases, especially after D7910.

TO verify the state transition cases is trivial as the state error policy in the W3C spec is very simple:

1. start() can be called only when it is "inactive" state.
2. All other functions (pause(), resume(), stop(), requestData()) must not be called when it's "inactive" state, regardless of the order and how many number they are called.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5577f9e95a9
Fix and add test_mediarecorder_state_transition.html in tests. r=jya

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f5577f9e95a9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Might as well take this test-only fix on Beta also since bug 1496383 landed there.

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/438c1b303119