Closed Bug 1496382 Opened 6 years ago Closed 6 years ago

Don't use "groupbox" for Preferences subdialogs

Categories

(Firefox :: Settings UI, enhancement, P1)

Product:
Firefox
Component:
Settings UI
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(1 file)

Bug 1496382 - Don't use "groupbox" for Preferences subdialogs. r=jaws
46 bytes, text/x-phabricator-request
Details | Review
This is required to remove the "groupbox" and "caption" elements, and simplifies the code as well.
This is required to remove the "groupbox" and "caption" elements, and simplifies the code as well.
Running tests to see if any of them depends on the DOM structure of the dialogs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a28c83a2af2c4889a6ef7f77b63920e2043b68ea
Blocks: 1429940
Jared, did you see this review? This is independent from bug 1429940.
Flags: needinfo?(jaws)
Sorry for the delay. I have just reviewed your patch.
Flags: needinfo?(jaws)
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/80983dcd1180 Don't use "groupbox" for Preferences subdialogs. r=jaws
https://hg.mozilla.org/mozilla-central/rev/80983dcd1180
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
cc'ing Marco to be aware of
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: