Closed Bug 1496400 Opened Last year Closed 11 months ago

Remove common.css

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ladybenko, Assigned: ladybenko)

References

Details

Attachments

(1 file)

Duplicate the variables and the rules we need from common.css, following our CSS convention, so we don't need to import this stylesheet –which has rules than interfere with our CSS cascade
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ba65c3ad1ff
Remove common.css r=jdescottes,daisuke
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/5a25082188fd
Backed out changeset 5ba65c3ad1ff for failing devtools' browser_parsable_css.js. CLOSED TREE
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/9a0a97d16ecc
Backed out changeset 5ba65c3ad1ff for failing devtools' browser_parsable_css.js: fix eslint failures. CLOSED TREE
Those backout are for

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&group_state=expanded&revision=5ba65c3ad1ffc76c31dcfda165b87afc1269b415&selectedJob=206610403

TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--warning-50` is not referenced -
TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--worker-status-font-size` is not referenced -
Flags: needinfo?(balbeza)
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/290fb2f0aec3
Backed out changeset 5ba65c3ad1ff for failing devtools' browser_parsable_css.js: fix eslint failures, part 2. CLOSED TREE
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/d38486cbad8d
Backed out changeset 5ba65c3ad1ff for failing devtools' browser_parsable_css.js: add dangling comma to code added back. CLOSED TREE
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/0e7248074acf
Backed out changeset 5ba65c3ad1ff for failing devtools' browser_parsable_css.js: revert aboutdebugging.css which didn't get reverted during the backout
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad022c9aec53
Remove common.css r=jdescottes,daisuke
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/62096eab37f8
Fix ESLint comma-dangle failures. r=RyanVM on a CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/ad022c9aec53
https://hg.mozilla.org/mozilla-central/rev/62096eab37f8
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Flags: needinfo?(balbeza)
You need to log in before you can comment on or make changes to this bug.