Closed
Bug 1496419
Opened 7 years ago
Closed 7 years ago
Graphs break on manual operations
Categories
(Tree Management :: Perfherder, enhancement, P1)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: igoldan, Assigned: igoldan)
References
Details
Attachments
(1 file)
|
47 bytes,
patch
|
wlach
:
review+
jmaher
:
feedback+
|
Details | Diff | Splinter Review |
When nudging or manually creating an alert, the graphs break.
The requests to BE are still fulfilled, so refreshing the same page correctly shows the updated graphs.
Thus, we need to investigate the graph drawing mechanics and fix them, so we no longer need to do the clunky refresh.
| Assignee | ||
Updated•7 years ago
|
Assignee: nobody → igoldan
Comment 1•7 years ago
|
||
| Assignee | ||
Updated•7 years ago
|
Attachment #9015885 -
Attachment is patch: true
Attachment #9015885 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #9015885 -
Flags: feedback?(jmaher)
| Assignee | ||
Updated•7 years ago
|
Attachment #9015885 -
Attachment is patch: false
Attachment #9015885 -
Attachment mime type: text/plain → text/x-github-pull-request
Updated•7 years ago
|
Attachment #9015885 -
Flags: feedback?(jmaher) → feedback+
| Assignee | ||
Updated•7 years ago
|
Attachment #9015885 -
Attachment is patch: true
Attachment #9015885 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #9015885 -
Flags: review?(wlachance)
Comment 2•7 years ago
|
||
Comment on attachment 9015885 [details] [diff] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4123
(feel free to just mark my review as r+ yourself if I've already approved your changes on github)
Attachment #9015885 -
Flags: review?(wlachance) → review+
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/cfa2daf205c065b225cb4630ab97bf72e6fc022d
Bug 1496419 - Fix graphs when nudging/manually creating alerts (#4123)
Comment 4•7 years ago
|
||
This will be auto-deployed to stage in ~15-20 minutes and deployed to production some time this week.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•