1496432 - Upstream marionette_driver’s explicit wait class

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

The Marionette Python client has a pretty good implementation of a
poll-wait utility in
https://searchfox.org/mozilla-central/source/testing/marionette/client/marionette_driver/wait.py.
It is my personal opinion that it is superior to
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/support/wait.py
used in WPT.  This bug is to upstream our version of the explicit
wait utility to WPT.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Actually it turns out I need this for
https://bugzilla.mozilla.org/show_bug.cgi?id=1492499.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1496432: webdriver: rename support.wait to sync;

"sync", short for synchronisation, is a better name for a primitive
to reconcile state between the local and remote ends.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1496432: webdriver: use mozilla poll utility;

Mozilla's implementation of the explicit poll-waiting routine
is vastly superior to the one used by WPT.  This patch upstreams
testing/marionette/client/marionette_driver/wait.py to WPT.

Depends on D7735

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/330058affbc3
webdriver: rename support.wait to sync; r=whimboo
https://hg.mozilla.org/integration/autoland/rev/26607bdd2fbf
webdriver: use mozilla poll utility; r=whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13401 for changes under testing/web-platform/tests

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/330058affbc3
https://hg.mozilla.org/mozilla-central/rev/26607bdd2fbf

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13401
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/437766788?utm_source=github_status&utm_medium=notification)
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/JDrP5-l9QfObRXx-YfOh1A)

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged