Closed Bug 1496432 Opened Last year Closed Last year

Upstream marionette_driver’s explicit wait class

Categories

(Testing :: geckodriver, enhancement, P1)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(2 files)

The Marionette Python client has a pretty good implementation of a
poll-wait utility in
https://searchfox.org/mozilla-central/source/testing/marionette/client/marionette_driver/wait.py.
It is my personal opinion that it is superior to
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/support/wait.py
used in WPT.  This bug is to upstream our version of the explicit
wait utility to WPT.
Priority: -- → P3
Actually it turns out I need this for
https://bugzilla.mozilla.org/show_bug.cgi?id=1492499.
Assignee: nobody → ato
Blocks: 1492499
Status: NEW → ASSIGNED
Priority: P3 → P1
"sync", short for synchronisation, is a better name for a primitive
to reconcile state between the local and remote ends.
Mozilla's implementation of the explicit poll-waiting routine
is vastly superior to the one used by WPT.  This patch upstreams
testing/marionette/client/marionette_driver/wait.py to WPT.

Depends on D7735
Attachment #9014440 - Attachment description: bug 1496432: rename support.wait to sync; → bug 1496432: webdriver: rename support.wait to sync;
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/330058affbc3
webdriver: rename support.wait to sync; r=whimboo
https://hg.mozilla.org/integration/autoland/rev/26607bdd2fbf
webdriver: use mozilla poll utility; r=whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13401 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/330058affbc3
https://hg.mozilla.org/mozilla-central/rev/26607bdd2fbf
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Upstream PR merged
Component: Marionette → geckodriver
You need to log in before you can comment on or make changes to this bug.