1496478 - Scrolling while in the search bar changes default search engine

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[[:philipp]]

after the changes in bug 1460982 landed, when you have the search bar enabled and hover with your mouse over that element, the chosen default search engine will change when you start to scroll.

i managed to accidentally change my search engine a couple of times in the past days and couldn't pinpoint that to a particular action/behaviour until it came up in this thread: https://old.reddit.com/r/firefox/comments/9ldc9i/scrolling_on_search_box_changes_search_engine_how/

i think it is an undesirable regression as there isn't really any UI that is making the user aware that a change in search engines is taking place which can lead to a degraded search experience (and lost revenue). also currently the switch is taking place between all installed search providers and not only the ones that are enabled and visibly displayed in the search bar as one-off search engines.

Comment 1

[Brian Grinstead [:bgrins]]

Ah, I missed the [modifiers=accel] condition on the DOMMouseScroll event when migrating this https://dxr.mozilla.org/mozilla-beta/source/browser/components/search/content/search.xml#424. Thanks for filing.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1496478 - Only change the search engine when scrolling on searchbox if accel key is pressed;r=adw

The Custom Element migration missed the [modifiers=accel] in XBL on the DOMMouseScroll handler.

Comment 3

[Brian Grinstead [:bgrins]]

Confirmed with smaug that `event.getModifierState("Accel")` is equivalent behavior to `[modifiers=accel]` in XBL: https://mozilla.logbot.info/content/20181004#c15417997-c15418054

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a517eeb9e6
Only change the search engine when scrolling on searchbox if accel key is pressed;r=adw

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/01a517eeb9e6

Comment 6

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 64.0a1 (2018.10.04) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0b3 on Win 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.13.6.