Closed Bug 1496486 Opened Last year Closed Last year

Remove a lot of nsCSSValue usage.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(6 files, 1 obsolete file)

No description provided.
This needs a cssparser update which I already landed on inbound, to
include https://github.com/servo/rust-cssparser/pull/228.

Really sorry for the size of the patch.
This will actually be a proper version bump with the updated configure
check and such once that PR (https://github.com/eqrion/cbindgen/pull/213) is in
a release. I don't plan to land these changes before that.
We can't remove the defaulted constructors because we use them in
FindMatchingFontFaces.
Blocks: 1451178
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/ab92ed3e0a23
Remove a bunch of unused nsCSSValue code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/86382b2249f6
Remove nsCSSValue usage from font code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/8e465202c355
Remove GridTemplateAreas stuff from nsCSSValue. r=heycam
https://hg.mozilla.org/integration/autoland/rev/5cf44e254ac3
Remove some more leftover code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/6b740afea403
Bump cbindgen. r=heycam
leave-open to land the last bit.
Keywords: leave-open
Wow, somehow managed to break all builds but linux64, which is what I pushed with...

There's a mixture of:

 * Old libclang causing bindgen issues.
 * Missing include in gfxUserFontSet.h
 * Some compiler seems unhappy about doing switch on an enum class, and it doesn't consider it exhaustive enough... I'll add a MOZ_ASSERT_UNREACHABLE or something.

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=7193661b37b069c36b19dd518d8238c8d5856088

Should be enough to fix it.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/e8d8e2f3f00b
Remove a bunch of unused nsCSSValue code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/4dd15fa31474
Remove nsCSSValue usage from font code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/2f629a60f12c
Remove GridTemplateAreas stuff from nsCSSValue. r=heycam
https://hg.mozilla.org/integration/autoland/rev/7f843f4ee162
Remove some more leftover code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d2f1e35ee4b7
Bump cbindgen. r=heycam
Flags: needinfo?(emilio)
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35f51b769efe
Backed out 5 changesets for valgrind bustages. CLOSED TREE
I rewrote the computed value implementation to avoid allocating and this tricked
Valgrind.
    
There's nothing uninitialized or unsafe from the code in:
    
    https://hg.mozilla.org/integration/autoland/rev/4dd15fa31474#l28.68
Flags: needinfo?(emilio)
Attachment #9015602 - Flags: review?(nfroyd)
Attachment #9015602 - Flags: review?(jseward)
Attachment #9015602 - Flags: review?(nfroyd)
Attachment #9015602 - Flags: review?(jseward)
Attachment #9015602 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/02e58f0b7d60
Remove a bunch of unused nsCSSValue code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/473ff44d5f12
Remove nsCSSValue usage from font code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/9ac1296e4cc0
Remove GridTemplateAreas stuff from nsCSSValue. r=heycam
https://hg.mozilla.org/integration/autoland/rev/5febc1595fd4
Remove some more leftover code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/836472045b3b
Bump cbindgen. r=heycam
https://hg.mozilla.org/integration/autoland/rev/8ecaee03d38e
Valgrind suppression. rs=froydnj
Blocks: 1498571
Per discussion with jwatt I'll move the last patch to bug 1498571.
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Attachment #9014489 - Attachment is obsolete: true
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.