1496502 - [css-grid-2] Enable subgrid by default in Nightly (and early beta?)

Status: RESOLVED FIXED

(Core :: Layout: Grid, enhancement, P3)

Description

[Mats Palmgren (inactive)]

After the layout patches have landed and stabilized, we want
to enable the subgrid pref by default in Nightly builds,
and possibly in "early Beta" builds too.

Comment 1

[fantasai]

Btw, if the spec isn't in CR by the time you want to do this, shoot me a message, I'll strip it down and fast-track subgrid for you: AFAIK the open issues are all on other features.

Comment 2

[shaun]

A common use case I run across in my day to day is where I have elements within a grid item

For example: https://codepen.io/shaunrashid/pen/PGMgjx

Would subgrid allow me to align the elements across a row? For example, images would be top aligned with each other across a row with varying amounts of content in the headings? Or top aligning up the stack of links across the row?

Comment 3

[Eric A. Meyer]

I’m 100% in favor of this hitting Nightly as soon as possible, and pushing as wide as reasonable after that. This is a critical component of making Grid the powerhouse it promises to be. If nothing else, subgrid allows the use of grids without having to flatten document structures and thus lose semantic markup.

I’ve run into several situations where I wished I had subgrid, some of them similar to Shaun’s—flexbox can only take you so far in those scenarios, and it’s not nearly far enough.

Comment 4

[brendastorer]

The sooner the better! I am anxiously awaiting subgrid as well, for all the reasons Shaun and Eric outlined. I add a lot of divs to my markup and repeat CSS that are there to get around the limitations of only being able to style direct descendants.

Comment 5

[natalyathree]

It would be so great to have this in Nightly asap. In some designs I want to implement I feel like the nested grid tracks should absolutely have a relationship to the parent grid, and when they don't, I just opt for a 'simpler' design.

Cards with different length content are a perfect use case for me. CSS Grid came to the rescue when I was working on complex cards, and subgrid would really finish the job.

Comment 6

[miriam]

This would be a huge advance is CSS layout capability. We use grid regularly on both client and internal projects - and always have to go out of our way trying to work around this missing feature. The issues above are not edge-cases, but problems that arise with most practical grid uses. Can't wait to have it land in nightly!

Comment 7

[Stacy Kvernmo]

Subgrid is needed to ensure people markup isn't flattened which would cause accessibility issues in addition being an extremely useful tool for elements inside their parent grid containers. I'd love if it were implemented in Nightly!

Comment 8

[Chen Hui Jing]

A very common use-case is for a layout with grid items themselves having children that need to be laid out in a grid, while maintaining the same relationship with their grandparent grid, just like previous comments have described. Would be great for it to land ASAP so we can test out our ideas with it.

Comment 9

[Torsten Curdt]

I agree with the previous comments. It would be great to define a grid further up the tree. Using display:contents or repeating the grid on every parent are not great workarounds. Giving access to a grandparent grid seems close to required for this to be usable beyond the most simple use cases.

Comment 10

[Mats Palmgren (inactive)]

Attachment: Bug 1496502 - [css-grid-2] Enable subgrid by default in Nightly. r=dholbert

Comment 11

[Mats Palmgren (inactive)]

Blocked by bug 1466358 obviously.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e1d198ffd3e
[css-grid-2] Enable subgrid by default in Nightly.  r=dholbert

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1e1d198ffd3e