1496570 - Bugzilla doesn't attempt to decode form-urlencoded data without a content-type header

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: API, defect, P1)

Description

[Eric Ziegenhorn :ericz]

We have a script that synchronizes some data from Bugzilla to another service and it is currently logging this error:

[Thu Oct 04 20:00:18 2018] [ERROR] Error no=32000 talking to bugzilla: Could not parse the 'params' argument as valid JSON. Error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "assigned_to=Rob@mozi...") at /app/Bugzilla/WebService/Server/REST.pm line 377. Value:

which I was told may be a bugzilla regression hence this bug.

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Can you add the query you're using to fetch the data, and make the bug MoCo private if necessary?

Comment 2

[Dylan Hardison [:dylan] (he/him)]

369 out of 14,273,121 requests seem to exhibit this bug.

We're going to get a fix out tomorrow, before Pacific Coast wakes up anyway.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: GitHub Pull Request

Comment 4

[Dylan Hardison [:dylan] (he/him)]

The fix here is -- for the legacy CGI controller -- to assume 'application/x-www-form-urlencoded; charset=utf-8' when no content-type is present.

Comment 5

[David Lawrence [:dkl]]

Merged to master.

Comment 6

[Eric Ziegenhorn :ericz]

Works for me now, thanks!  FWIW it took a while to track down but the app makes a POST to e.g. https://bugzilla.mozilla.org/rest/bug/1495719 with content like:

'assigned_to=[e-mail]&token=23925-JfIavher'