Closed Bug 1496608 Opened Last year Closed Last year
Parent leaks Gecko Child Process Host on launch failure
46 bytes, text/x-phabricator-request
|Details | Review|
ContentParent disposes of its GeckoChildProcessHost instance in ActorDestroy, but that's never called if the process launch failed. I've confirmed that it leaks by editing the code to introduce artificial launch failures and watchpointing the vtable pointer; there should be a better way to do that.
Depends on D8939
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8ede2ebe6b7a Don't leak GeckoChildProcessHost when a content process fails to launch. r=mccr8
Backed out for failing very frequent automation.py crashes on mochitest and browser chrome tests Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=8b1f88d7bfeb1949060170ba51b6530db5e93c8e Failure rate: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=classified&failure_classification_id=2&fromchange=8b1f88d7bfeb1949060170ba51b6530db5e93c8e Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=214049603&repo=autoland&lineNumber=1633 Jed: i backed out the whole push because i was not sure what bug specifically started this. I commented here because this bug introduced a new intermittent: https://treeherder.mozilla.org/logviewer.html#?job_id=214042105&repo=autoland&lineNumber=5360
(In reply to Andreea Pavel [:apavel] from comment #3) > Jed: i backed out the whole push because i was not sure what bug > specifically started this. Thanks for the backout and the links. (For reference, the assertion that's failing was added in bug 1446161, but I think the reason it's failing is bug 1487287. There's also a Mac failure related to Web Replay, which definitely is bug 1487287.)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/1b92017b4865 Don't leak GeckoChildProcessHost when a content process fails to launch. r=mccr8
You need to log in before you can comment on or make changes to this bug.