1496617 - Unprefix `image-rendering: crisp-edges`

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[ExE Boss]

Stylo already understands `image-rendering: crisp-edges`, but Firefox doesn’t support it unprefixed yet, and with bug 1457333 hiding all prefixed values from DevTools auto‑complete, I’d suggest unprefixing this.

Comment 1

[Cameron McCormack (:heycam)]

WebKit also supports crisp-edges unprefixed these days, but before it did it supported a value called -webkit-optimize-contrast.  Removing the prefixed version may cause some breakage given https://css-tricks.com/keep-pixelated-images-pixelated-as-they-scale/#comment-1618989 says that the Autoprefixer tool outputs -webkit-optimize-contrast but not unprefixed crisp-edges.

Comment 2

[Cameron McCormack (:heycam)]

So how about we support the unprefixed value, leave the prefixed value in there for now, and try to remove it later.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

sgtm

Comment 4

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bd63ad4ce62dfe0e9911fd1ee0502597bbbfd0a

Comment 5

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc4c2d1b63bca0d947f4bb9c09c53082975e69a3&group_state=expanded

Comment 6

[Cameron McCormack (:heycam)]

Attachment: Bug 1496617 - Part 1: Support unprefixed image-rendering:crisp-edges

For now, we keep supporting the prefixed version, since there are examples/instructions
on the Web that don't include an unprefixed value.

Comment 7

[Cameron McCormack (:heycam)]

Attachment: Bug 1496617 - Part 2: Fix inconsistent CRISPEDGES constant name

Depends on D10451

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cab84e74394
Part 1: Support unprefixed image-rendering:crisp-edges r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/7e3f37db75a4
Part 2: Fix inconsistent CRISPEDGES constant name r=emilio

Comment 9

[Kohei Yoshino [:kohei]]

Posted site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/image-rendering-crisp-edges-has-been-unprefixed/

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1cab84e74394
https://hg.mozilla.org/mozilla-central/rev/7e3f37db75a4

Comment 11

[ExE Boss]

Attachment: MDN: Browser compatibility table update

Comment 12

[Chris Mills [:cmills]]

Exe Boss has updated the compat data for this, and I've added a note to the Fx 65 rel notes:

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#CSS

I think we can call this DDC.

Comment 13

[Gregg Tavares]

Here's hoping you can revisit pixelated which is working in Chrome and Safari but not Firefox

https://bugzilla.mozilla.org/show_bug.cgi?id=856337