Closed Bug 1496629 Opened 6 years ago Closed 5 years ago

Intermittent Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:500

Categories

(Core :: XPCOM, defect, P5)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox-esr60 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: froydnj)

References

Details

(Keywords: assertion, intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

use RefPtr rather than nsCOMPtr to avoid data race.
1.00 KB, patch
kmag
: review+
Details | Diff | Splinter Review 
Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=203511767&repo=mozilla-central

https://queue.taskcluster.net/v1/task/WNNujAFnTzmeBC-cRd4cfQ/runs/0/artifacts/public/logs/live_backing.log

16:22:21     INFO - TEST-INFO | started process GECKO(1004)
16:22:21     INFO - GECKO(1004) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/w0/1f74m9v11555z98p8vzgjlvw00000w/T/tmpDRPvyU.mozrunner/runtests_leaks.log
16:22:21     INFO - GECKO(1004) | [1004, Main Thread] WARNING: Re-registering a CID?: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 593
16:22:21     INFO - GECKO(1004) | Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:500
16:22:21     INFO - GECKO(1004) | #01: mozilla::ScriptPreloader::InitCache(nsTSubstring<char16_t> const&) [js/xpconnect/loader/ScriptPreloader.cpp:511]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #02: mozilla::ScriptPreloader::GetChildSingleton() [js/xpconnect/loader/ScriptPreloader.cpp:169]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #03: mozilla::ScriptPreloader::GetSingleton() [js/xpconnect/loader/ScriptPreloader.cpp:124]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #04: NS_InitXPCOM2 [xpcom/build/XPCOMInit.cpp:720]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #05: ScopedXPCOMStartup::Initialize() [toolkit/xre/nsAppRunner.cpp:1483]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #06: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:4920]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #07: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5016]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #08: main [browser/app/nsBrowserApp.cpp:233]
16:22:21     INFO - 
16:25:21     INFO - runtests.py | Waiting for browser...
16:25:21     INFO - TEST-INFO | Main app process: exit 1
See Also: → 1496635
See Also: 1496635 →
Assignee: nobody → continuation
Depends on: 1455637
Assignee: continuation → nobody
QA Contact: nfroyd
QA Contact: nfroyd
I'm shortening the summary in the hope that this will let the tree herder matcher actually realize this bug exists.
Summary: Intermittent GECKO(1004) | Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:500 → Intermittent Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:500
In the last 7 days there have been 33 failures on OS X, debug.
Whiteboard: [stockwell needswork]
This is still the script preloader, but it looks like it is happening inside mozilla::ScriptPreloader::Observe() calling into ScriptPreloader::InvalidateCache() instead. Any ideas, Kris?
Flags: needinfo?(kmaglione+bmo)
This is basically the same issue as bug 1455637.
Assignee: nobody → kmaglione+bmo
Flags: needinfo?(kmaglione+bmo)
There are 33 failures in the last 7 days.
They occur on osx-10-10 and the affected build type is debug.
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209739863&repo=autoland&lineNumber=36212
kmag: Hi, are there any updates on this? Thanks!
Flags: needinfo?(kmaglione+bmo)
There are 28 occurences in the last 7 days.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=213641540&repo=autoland&lineNumber=5066

6:44:13     INFO - TEST-OK | browser/extensions/formautofill/test/mochitest/test_on_address_submission.html | took 2412ms
16:44:13     INFO - GECKO(969) | ++DOMWINDOW == 12 (0x11f7a1400) [pid = 971] [serial = 26] [outer = 0x11e422800]
16:44:13     INFO - TEST-START | Shutdown

16:44:20     INFO - GECKO(974) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/ck/_3cq3hgd2fs3v66_hkltshhw00000x/T/tmpnsVPM7.mozrunner/runtests_leaks_tab_pid978.log
16:44:20     INFO - GECKO(974) | [Parent 974, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 342
16:44:20     INFO - GECKO(974) | 1543020260774	Marionette	TRACE	1 <- [1,2,null,{"value":"special-powers@mozilla.org"}]
16:44:20     INFO - GECKO(974) | 1543020260801	Marionette	TRACE	1 -> [0,3,"Addon:Install",{"path":"/var/folders/ck/_3cq3hgd2fs3v66_hkltshhw00000x/T/tmp_6TmSQ.zip","temporary":false}]
16:44:20     INFO - GECKO(974) | Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:500
16:44:21     INFO - runtests.py | Waiting for browser...
16:45:48     INFO - GECKO(974) | #01: mozilla::ScriptPreloader::Observe(nsISupports*, char const*, char16_t const*) [xpcom/base/nsCOMPtr.h:484]
16:45:48     INFO - 
16:45:48     INFO - GECKO(974) | #02: nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverList.cpp:78]
16:45:48     INFO - 
16:45:48     INFO - GECKO(974) | #03: nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) [mozglue/misc/TimeStamp.h:521]
16:45:48     INFO - 
16:45:48     INFO - GECKO(974) | Hit MOZ_CRASH(Aborting on channel error.) at /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2658
16:45:48     INFO - GECKO(974) | Hit MOZ_CRASH(Aborting on channel error.) at /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2658

Kris, since bug 1455637 got fixed, can this be fixed as well?
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [stockwell unknown]
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [stockwell needswork:owner]
There are 31 total failures in the last 7 days, all on osx-10-10. Kris are there any updates here?
There are 30 failures asociated to this bug in the last 7 days. These are occurring on OSX debug builds.

:froydnj can you take a look at this?
Flags: needinfo?(nfroyd)
This is the same fix as bug 1455637...but it feels just as dodgy here as it did
in that bug.  The better fix would be to just lock around the named thread
call, yes?
Attachment #9032719 - Flags: review?(kmaglione+bmo)
Flags: needinfo?(nfroyd)
Comment on attachment 9032719 [details] [diff] [review]
use RefPtr rather than nsCOMPtr to avoid data race.

Review of attachment 9032719 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #9032719 - Flags: review?(kmaglione+bmo) → review+
Assignee: kmaglione+bmo → nfroyd
Flags: needinfo?(kmaglione+bmo)
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c43184f50b7a
use RefPtr rather than nsCOMPtr to avoid data race. r=kmag
https://hg.mozilla.org/mozilla-central/rev/c43184f50b7a
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
See Also: → 1540035
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: