1496629 - Intermittent Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:500

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=203511767&repo=mozilla-central

https://queue.taskcluster.net/v1/task/WNNujAFnTzmeBC-cRd4cfQ/runs/0/artifacts/public/logs/live_backing.log

16:22:21     INFO - TEST-INFO | started process GECKO(1004)
16:22:21     INFO - GECKO(1004) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/w0/1f74m9v11555z98p8vzgjlvw00000w/T/tmpDRPvyU.mozrunner/runtests_leaks.log
16:22:21     INFO - GECKO(1004) | [1004, Main Thread] WARNING: Re-registering a CID?: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 593
16:22:21     INFO - GECKO(1004) | Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:500
16:22:21     INFO - GECKO(1004) | #01: mozilla::ScriptPreloader::InitCache(nsTSubstring<char16_t> const&) [js/xpconnect/loader/ScriptPreloader.cpp:511]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #02: mozilla::ScriptPreloader::GetChildSingleton() [js/xpconnect/loader/ScriptPreloader.cpp:169]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #03: mozilla::ScriptPreloader::GetSingleton() [js/xpconnect/loader/ScriptPreloader.cpp:124]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #04: NS_InitXPCOM2 [xpcom/build/XPCOMInit.cpp:720]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #05: ScopedXPCOMStartup::Initialize() [toolkit/xre/nsAppRunner.cpp:1483]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #06: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:4920]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #07: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5016]
16:22:21     INFO - 
16:22:21     INFO - GECKO(1004) | #08: main [browser/app/nsBrowserApp.cpp:233]
16:22:21     INFO - 
16:25:21     INFO - runtests.py | Waiting for browser...
16:25:21     INFO - TEST-INFO | Main app process: exit 1

Comment 4

[Andrew McCreight [:mccr8]]

I'm shortening the summary in the hope that this will let the tree herder matcher actually realize this bug exists.

Comment 5

[Intermittent Failures Robot]

7 failures in 2708 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 2
* mozilla-central: 2
* try: 1
* mozilla-inbound: 2

Platform breakdown:
* osx-10-10: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-10-01&endday=2018-10-07&tree=all

Comment 6

[Intermittent Failures Robot]

10 failures in 2740 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 7
* mozilla-inbound: 3

Platform breakdown:
* osx-10-10: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-10-08&endday=2018-10-14&tree=all

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

In the last 7 days there have been 33 failures on OS X, debug.

Comment 8

[Andrew McCreight [:mccr8]]

This is still the script preloader, but it looks like it is happening inside mozilla::ScriptPreloader::Observe() calling into ScriptPreloader::InvalidateCache() instead. Any ideas, Kris?

Comment 9

[Kris Maglione [:kmag]]

This is basically the same issue as bug 1455637.

Comment 10

[Intermittent Failures Robot]

40 failures in 2759 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #50 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 18
* autoland: 16
* mozilla-beta: 1
* mozilla-central: 4
* try: 1

Platform breakdown:
* osx-10-10: 37
* linux32: 2
* linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-10-15&endday=2018-10-21&tree=all

Comment 11

[Intermittent Failures Robot]

23 failures in 2584 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 10
* mozilla-inbound: 10
* mozilla-central: 3

Platform breakdown:
* linux64-qr: 1
* linux32: 1
* osx-10-10: 21

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-10-22&endday=2018-10-28&tree=all

Comment 12

[Eliza Balazs [:ebalazs_]]

There are 33 failures in the last 7 days.
They occur on osx-10-10 and the affected build type is debug.
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209739863&repo=autoland&lineNumber=36212
kmag: Hi, are there any updates on this? Thanks!

Comment 13

[Intermittent Failures Robot]

35 failures in 2978 pushes (0.012 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-central: 4
* autoland: 20
* mozilla-beta: 2
* mozilla-inbound: 8
* try: 1

Platform breakdown:
* osx-10-10: 35

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-10-29&endday=2018-11-04&tree=all

Comment 14

[Intermittent Failures Robot]

25 failures in 3007 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 7
* mozilla-central: 2
* mozilla-beta: 1
* autoland: 15

Platform breakdown:
* osx-10-10: 25

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-11-05&endday=2018-11-11&tree=all

Comment 15

[Intermittent Failures Robot]

17 failures in 2917 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-release: 1
* autoland: 8
* mozilla-inbound: 8

Platform breakdown:
* osx-10-10: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-11-12&endday=2018-11-18&tree=all

Comment 16

[Andreea Pavel [:apavel]]

There are 28 occurences in the last 7 days.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=213641540&repo=autoland&lineNumber=5066

6:44:13     INFO - TEST-OK | browser/extensions/formautofill/test/mochitest/test_on_address_submission.html | took 2412ms
16:44:13     INFO - GECKO(969) | ++DOMWINDOW == 12 (0x11f7a1400) [pid = 971] [serial = 26] [outer = 0x11e422800]
16:44:13     INFO - TEST-START | Shutdown

16:44:20     INFO - GECKO(974) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/ck/_3cq3hgd2fs3v66_hkltshhw00000x/T/tmpnsVPM7.mozrunner/runtests_leaks_tab_pid978.log
16:44:20     INFO - GECKO(974) | [Parent 974, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 342
16:44:20     INFO - GECKO(974) | 1543020260774	Marionette	TRACE	1 <- [1,2,null,{"value":"[e-mail]"}]
16:44:20     INFO - GECKO(974) | 1543020260801	Marionette	TRACE	1 -> [0,3,"Addon:Install",{"path":"/var/folders/ck/_3cq3hgd2fs3v66_hkltshhw00000x/T/tmp_6TmSQ.zip","temporary":false}]
16:44:20     INFO - GECKO(974) | Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:500
16:44:21     INFO - runtests.py | Waiting for browser...
16:45:48     INFO - GECKO(974) | #01: mozilla::ScriptPreloader::Observe(nsISupports*, char const*, char16_t const*) [xpcom/base/nsCOMPtr.h:484]
16:45:48     INFO - 
16:45:48     INFO - GECKO(974) | #02: nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverList.cpp:78]
16:45:48     INFO - 
16:45:48     INFO - GECKO(974) | #03: nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) [mozglue/misc/TimeStamp.h:521]
16:45:48     INFO - 
16:45:48     INFO - GECKO(974) | Hit MOZ_CRASH(Aborting on channel error.) at /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2658
16:45:48     INFO - GECKO(974) | Hit MOZ_CRASH(Aborting on channel error.) at /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2658

Kris, since bug 1455637 got fixed, can this be fixed as well?

Comment 17

[Intermittent Failures Robot]

26 failures in 2387 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 6
* autoland: 18
* mozilla-beta: 1
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 26

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-11-19&endday=2018-11-25&tree=all

Comment 18

[Andreea Pavel [:apavel]]

There are 31 total failures in the last 7 days, all on osx-10-10. Kris are there any updates here?

Comment 19

[Intermittent Failures Robot]

36 failures in 2808 pushes (0.013 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 9
* autoland: 17
* mozilla-beta: 2
* mozilla-central: 7
* try: 1

Platform breakdown:
* osx-10-10: 36

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-11-26&endday=2018-12-02&tree=all

Comment 20

[Intermittent Failures Robot]

15 failures in 1862 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* mozilla-release: 1
* mozilla-central: 4
* autoland: 7

Platform breakdown:
* osx-10-10: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-12-03&endday=2018-12-09&tree=all

Comment 21

[Intermittent Failures Robot]

25 failures in 2485 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 1
* autoland: 17
* mozilla-inbound: 4
* mozilla-central: 3

Platform breakdown:
* osx-10-10: 25

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-12-10&endday=2018-12-16&tree=all

Comment 22

[Andrei Ciure[:aciure]]

There are 30 failures asociated to this bug in the last 7 days. These are occurring on OSX debug builds.

:froydnj can you take a look at this?

Comment 23

[Nathan Froyd [:froydnj]]

Attachment: use RefPtr rather than nsCOMPtr to avoid data race.

This is the same fix as bug 1455637...but it feels just as dodgy here as it did
in that bug.  The better fix would be to just lock around the named thread
call, yes?

Comment 24

[Kris Maglione [:kmag]]

Comment on attachment 9032719 [details] [diff] [review]
use RefPtr rather than nsCOMPtr to avoid data race.

Review of attachment 9032719 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c43184f50b7a
use RefPtr rather than nsCOMPtr to avoid data race. r=kmag

Comment 26

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c43184f50b7a

Comment 27

[Intermittent Failures Robot]

23 failures in 2648 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 4
* mozilla-inbound: 4
* autoland: 15

Platform breakdown:
* osx-10-10: 23

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2018-12-17&endday=2018-12-23&tree=all

Comment 28

[Intermittent Failures Robot]

1 failures in 2627 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform breakdown:

• osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496629&startday=2019-01-07&endday=2019-01-13&tree=all