1496638 - [FxA Commands] Instrument fetchMissedRemoteCommands with telemetry

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Edouard Oger [:eoger]]

Context in fxa-auth-server discussion [0].

We currently have no idea how many messages we are missing because of a Push notification defect.
Having some telemetry on the number of messages we're receiving using the fetchMissedRemoteCommands recovery method should help us make better decisions in the future in that regard.

[0] https://github.com/mozilla/fxa-auth-server/issues/2653

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1496638 - Instrument fetchMissedRemoteCommands with telemetry

Comment 2

[Chris H-C :chutten]

FYI this will require Data Collection Review: https://wiki.mozilla.org/Firefox/Data_Collection

Comment 3

[Edouard Oger [:eoger]]

Attachment: data_collection_request_form.md

Thank you, I've attached the document.
Will request for review if Mark is happy with the patch.

Comment 4

[Chris H-C :chutten]

Comment on attachment 9014895 [details]
data_collection_request_form.md

Preliminary note:
The review says "We will collect this data until Firefox 68 included." An "expires_in_version" of "68" means the first version the measure is expired in is 68. It is exclusive, in other words. If you're like to have the data collected in 68, please use "69" for the "expires_in_version". If you choose to go this route you don't need to re-apply for Data Collection Review, just note that in a comment on this bug.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, expires in 68. (or 69, see note)

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? 

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on, all channels.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :eoger, you are responsible for renewing or removing the collection before it expires.

---
Result: datareview+

Comment 5

[Edouard Oger [:eoger]]

Thank you for the quick review, I think 68 will give us a good amount of time to collect relevant data.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ae5b0d96fab
Instrument fetchMissedRemoteCommands with telemetry r=markh

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1ae5b0d96fab