1496650 - WinTaskbar::GetAppUserModelID doesn't return valid AppID on 64-bit Firefox when 32bit Firefox is installed

Status: NEW

(Core :: Widget: Win32, defect, P3)

Description

[Makoto Kato [:m_kato]]

Although I have landed bug 1155505 to support toast notification API, I found rarely environment that still uses XUL alert even if Windows 10 ver 1809.

This API requires valid AppID.  But this environment doesn't use valid AppID.  So when I debug this, WinTaskbar::GetAppUserModelID returns false even if there is HKLM/Software/Mozilla/Firefox/TaskBarIDs.  Since this environment installed Firefox 32bit (now it was alyready uninstalled), there is HKLM/Software/WOW6432Node/Mozilla/Firefox/TaskBarIDs as garbage.

So WinTaskbar::GetAppUserModelID should read native registry only (don't read WOW6432Node).

Comment 1

[[e-mail] (:bhearsum)]

Is this still an issue?

I think this may have been fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1602195, which added a fallback to do runtime generation of the AUMID if it's not found in the registry.

Comment 2

[Makoto Kato [:m_kato]]

If user uses 32-bit Firefox on 64-bit Windows, I think that this issue is still existed. But our Firefox installer will update to 64-bit if windows is 64bit version. So this is low priority (or we can resolve this as WONTFIX).

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Makoto Kato [:m_kato] from comment #2)

If user uses 32-bit Firefox on 64-bit Windows, I think that this issue is still existed. But our Firefox installer will update to 64-bit if windows is 64bit version. So this is low priority (or we can resolve this as WONTFIX).

This is true, but only for users with more than 2GB of RAM (and also doesn't happen for the full installer at all). I agree it's not super high priority, but AUMID is getting more and more important, so we should probably address this if it's not already fixed...