Closed Bug 1496698 Opened 5 years ago Closed 5 years ago

Remove Custom Elements polyfill from Web Payments UI

Categories

(Firefox :: WebPayments UI, enhancement, P1)

Product:
Firefox
Component:
WebPayments UI
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [webpayments])

Attachments

(2 files)

Bug 1496698 - Remove Custom Elements polyfill from Web Payments UI. r?jaws
46 bytes, text/x-phabricator-request
Details | Review
Bug 1496698 - Remove res/vendor from jar.mn; r=MattN
46 bytes, text/x-phabricator-request
Details | Review 
We no longer need this as it's enabled by default and riding the trains. This will also reveal errors that it was swallowing.
Flags: qe-verify-
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/d58b6e90927f
Remove Custom Elements polyfill from Web Payments UI. r=jaws
https://hg.mozilla.org/mozilla-central/rev/d58b6e90927f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Should res/vendor/* be removed from jar.mn now?

https://dxr.mozilla.org/mozilla-central/rev/b3158d143d833ec52c938e5235c1f86409fb764b/browser/components/payments/jar.mn#29

The fact that the directory no longer exists seems to cause the build backend to always be out-of-date in some cases.
Flags: needinfo?(MattN+bmo)
(In reply to Michael Shal [:mshal] from comment #4)
> Should res/vendor/* be removed from jar.mn now?

Yes, probably.

> https://dxr.mozilla.org/mozilla-central/rev/
> b3158d143d833ec52c938e5235c1f86409fb764b/browser/components/payments/jar.
> mn#29
> 
> The fact that the directory no longer exists seems to cause the build
> backend to always be out-of-date in some cases.

r=me on a patch to delete that line.
Flags: needinfo?(MattN+bmo)
Followup to remove the now non-existent directory from the manifest.

MozReview-Commit-ID: 5grb4TgoBsT
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7de161eb2e11
Remove res/vendor from jar.mn; r=MattN
You need to log in before you can comment on or make changes to this bug.