1496802 - Allow adding local html file as topsites

Status: NEW

(Firefox :: Top Sites, enhancement, P5)

Description

[salman]

Attachment: screenshot1.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

1. Install the latest Firefox ESR on Debian Stable (Firefox version: 60.2.2esr, Debian version: 9.5)

2. Click on 'TOP SITES' > '+ Add Top Site'

3. Introduce a local html file like, for example:
    3.1. Title: python3 doc
    3.2. URL: file:///usr/share/doc/python3.5/html/index.html

4. save it

5. the file has been added to the 'TOP SITES' list.



Actual results:

now we get an error if we click on the link, which we just created. (screenshot1)

if we look at the address bar the ':' has been removed from the address, and the address has been changed to file///usr/share/doc/python3.5/html/index.html

if we click on 'edit' to see what has happend to address, we see this address in the URL section, http://file:///usr/share/doc/python3.5/html/index.html


Expected results:

it should open the address correctly, without modifying it.

Comment 1

[Tim Spurway [:tspurway]]

adding files to top sites is not supported but we could do a better job of reporting the error

Comment 2

[salman]

(In reply to Tim Spurway [:tspurway] from comment #1)
> adding files to top sites is not supported but we could do a better job of
> reporting the error

If this is the case, a frequently opened html file shouldn't also be *automatically* added to the TOP SITES. But it will be added.

I have frequently opened this Python3 html file with Firefox and it has been added *automatically* to the TOP SITES. But it is also not working. Nothing happens when I click on it.

Comment 3

[Gurleen Kaur]

Hi,
I would like to work on this. Can someone assign this to me?

Comment 4

[PhoenixAbhishek]

Hi, I am Phoenix, a participant for the current Outreachy round.
I am on a Windows machine.
If it's possible to work on this issue from a Windows system I would like to take this forward and contribute.

Comment 5

[kerlyn]

Hi,
I wish to work on this issue. I am on a linux system.

Comment 6

[lekhikadugtal]

I'm an outreachy aspirant. I would like to work on this issue.

Comment 7

[lekhikadugtal]

Hey Salman, I tried reproducing steps but the top-sites section doesn't allow any local files to be added.
As adding local files is usually not supported, so was the bug of adding local files was fixed in some other issue.

Comment 8

[afshan.shokath]

Hey Salman, I am an outreachy applicant, can I be assigned this bug?

Comment 9

[Karan Sapolia]

(In reply to lekhikadugtal from comment #7)

Hey Salman, I tried reproducing steps but the top-sites section doesn't allow any local files to be added.
As adding local files is usually not supported, so was the bug of adding local files was fixed in some other issue.

I second this. Adding local url shows a visual alert of 'valid URL required' and does not allow the file to be saved.

(In reply to salman from comment #2)

(In reply to Tim Spurway [:tspurway] from comment #1)

adding files to top sites is not supported but we could do a better job of
reporting the error

If this is the case, a frequently opened html file shouldn't also be
automatically added to the TOP SITES. But it will be added.

I have frequently opened this Python3 html file with Firefox and it has been
added automatically to the TOP SITES. But it is also not working. Nothing
happens when I click on it.

Do not know about the automatic visibility of frequently opened local files in 'Top Sites', others could help by reporting if they see frequently opened local html pages listed in top sites. About disabling/keeping this usage, I think keeping it will be more helpful and infact the ability to click on it and open the local html page should be provided. The core issue is the inability of being able to open local links from 'Top Sites', I think if that issue exists in the bugtracker, we should link to it and start working on it.

Comment 10

[afshan.shokath]

Can I work on this issue? It still shows unassigned.

Comment 11

[salman]

(In reply to Karan Sapolia from comment #9)

(In reply to lekhikadugtal from comment #7)

Hey Salman, I tried reproducing steps but the top-sites section doesn't allow any local files to be added.
As adding local files is usually not supported, so was the bug of adding local files was fixed in some other issue.

I second this. Adding local url shows a visual alert of 'valid URL required' and does not allow the file to be saved.

Hey Karan,

As I have indicated in my bug report, this is the case in Firefox ESR and and not the latest released version of Firefox. I checked the feature again, and I was able to add an existing html file to the TOP SITES of Firefox ESR (60.5.1esr).

Comment 12

[Karan Sapolia]

(In reply to salman from comment #11)

(In reply to Karan Sapolia from comment #9)

(In reply to lekhikadugtal from comment #7)

Hey Salman, I tried reproducing steps but the top-sites section doesn't allow any local files to be added.
As adding local files is usually not supported, so was the bug of adding local files was fixed in some other issue.

I second this. Adding local url shows a visual alert of 'valid URL required' and does not allow the file to be saved.

Hey Karan,

As I have indicated in my bug report, this is the case in Firefox ESR and and not the latest released version of Firefox. I checked the feature again, and I was able to add an existing html file to the TOP SITES of Firefox ESR (60.5.1esr).

Oh! right! My bad. Yes, I was checking in Firefox release ver. 65.

Comment 13

[afshan.shokath]

Is anybody still working on this? If yes, then please reply with yes.

Comment 14

[Johannes Zellner]

Not sure why this is still open. At least ff 71 on Linux now reports a form validation error "Valid URL required" which looks correct to me.

Comment 15

[joshfeltonm]

(In reply to Johannes Zellner from comment #14)

Not sure why this is still open. At least ff 71 on Linux now reports a form validation error "Valid URL required" which looks correct to me.

-- I get the same thing on Mac. Adding local files to top pages could be a feature request though.

Comment 16

[paytonmcl]

Would I be able to get assigned this to allow local URLs to be stored in Top Sites?

Comment 17

[Larry Bordowitz]

The initial bug appears to be solved. Maybe there should be another ticket opened for a feature request, and this one should be closed out.

Comment 18

[Adrian Florinescu [:aflorinescu]]

(In reply to Larry Bordowitz from comment #17)

The initial bug appears to be solved. Maybe there should be another ticket opened for a feature request, and this one should be closed out.

Although I don't know how much value such a feature - allowing local files as custom topsites - would bring to the topsites section, let's morph this issue into an enhancement tracking exactly that.

Comment 19

[Kian]

Is it possible to implement this without changing the behavior mentioned in the link (Firefox does not open links to local files)?

https://unix.stackexchange.com/questions/606738/firefox-no-longer-opens-local-files