1496818 - Calendar on Daily 64.0a1 breaks "Select All" in the message list

Status: RESOLVED DUPLICATE of bug 1498588

(Calendar :: General, defect)

Description

[Ariel Poliak]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

I enabled Lightning 6.6a1 on my Thunderbird Daily (build ID 20181004100100), because it had been disabled since the removal of support for XUL-based addons.
I Restarted Thunderbird out of habit, then attempted to use Command+A to select all messages on a folder hosted in an IMAP server. 


Actual results:

The following error was logged to the console when using the keyboard shortcut:

TypeError: aTab is undefined; can't access its "mode" property[Learn More] mail3PaneWindowCommands.js:984:9
	doCommand chrome://messenger/content/mail3PaneWindowCommands.js:984:9
	doCommand chrome://calendar/content/calendar-common-sets.js:427:21


I also attempted to use Edit > Select > Select All in the menu, with similar results:

An error occurred executing the cmd_selectAll command: [Exception... "[JavaScript Error: "aTab is undefined; can't access its "mode" property" {file: "chrome://messenger/content/mail3PaneWindowCommands.js" line: 984}]'[JavaScript Error: "aTab is undefined; can't access its "mode" property" {file: "chrome://messenger/content/mail3PaneWindowCommands.js" line: 984}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 81"  data: yes] globalOverlay.js:83

Upon disabling Lightning and restarting Thunderbird, Select All functionality was restored in the message list.


Expected results:

All messages on the selected IMAP folder would be selected

Comment 1

[[:MakeMyDay]]

Confirming. We don't pass in a tab at [1], but that code isn't changed for ages and its working well on TB52 at least. Probably another falloout of the wx conversion.

[1] https://searchfox.org/comm-central/source/calendar/base/content/calendar-common-sets.js#427